NEW 46732
Add a pre commit pass that checks for missing platform test expectations 
https://bugs.webkit.org/show_bug.cgi?id=46732
Summary Add a pre commit pass that checks for missing platform test expectations
Erik Arvidsson
Reported 2010-09-28 09:39:48 PDT
As a human I tend to forget things and that is why tools are good. If I upload or land a patch that updates a test expectation it would be nice to have a script that checks if there is a platform specific expectation for the same test and then warns the user unless the patch also updates the platform specific tests. After using webkit-patch upload (or land?) I would like to see something like this: The following test(s) has platform specific expectations: fast/dom/Window/window-properties.html: platform/gtk/fast/dom/Window/window-properties-expected.txt platform/qt/fast/dom/Window/window-properties-expected.txt platform/qt/fast/dom/Window/window-property-descriptors.html platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt platform/qt/fast/dom/Window/window-property-descriptors-expected.txt but this patch does not update these. Are you sure you want to continue? [Y/n]
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-09-28 11:14:50 PDT
Sounds doable.
Adam Barth
Comment 2 2010-09-28 12:41:09 PDT
Yep. We already know where to look for these files for the rebaseline command.
Note You need to log in before you can comment on or make changes to this bug.