Bug 46724 – Web Inspector: move pauseOnExceptionState under control of InspectorState

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

%subj%

[Ilya Tikhonovsky]

Created attachment 69053 [details]
[patch] initial version.

[Yury Semikhatsky]

Comment on attachment 69053 [details]
[patch] initial version.

View in context: https://bugs.webkit.org/attachment.cgi?id=69053&action=review

> WebCore/inspector/InspectorController.cpp:263
> +    (*state)->setNumber(pauseOnExceptionsStateStateName, ScriptDebugServer::shared().pauseOnExceptionsState());

This is the only usage of ScriptDebugServer left in the IC, I should have removed when I was extracting InspectorDebuggerAgent. Could you move this accessor into Inspector  debugger agent and check here if the agent is present, it should cover both cases of debugger always enabled and debugger enabled manually.

> WebCore/inspector/front-end/inspector.js:595
> +        if ("updatePauseOnExceptionsState" in inspectorState)

you check for presence of one name but then access another field

[Ilya Tikhonovsky]

Created attachment 69093 [details]
[patch] second iteration

comments addressed

[Yury Semikhatsky]

Comment on attachment 69093 [details]
[patch] second iteration

View in context: https://bugs.webkit.org/attachment.cgi?id=69093&action=review

> WebCore/inspector/InspectorController.cpp:264
> +        (*state)->setNumber(pauseOnExceptionsStateStateName, m_debuggerAgent->pauseOnExceptionsState());

Now we can remove #include "ScriptDebugServer.h". Please do this before landing.

[Ilya Tikhonovsky]

Committed r68635
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorDebuggerAgent.h
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorDebuggerAgent.cpp
	M	WebCore/inspector/Inspector.idl
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/inspector.js
r68635 = b05398cb12412b6f9b65099ae5f5526aab37c5a0 (refs/remotes/trunk)