RESOLVED FIXED 46717
check USE(GSTREAMER) instead of ENABLE(VIDEO) in gstreamer/ files 
https://bugs.webkit.org/show_bug.cgi?id=46717
Summary check USE(GSTREAMER) instead of ENABLE(VIDEO) in gstreamer/ files
Philippe Normand
Reported 2010-09-28 05:21:02 PDT
USE(GSTREAMER) is already checked in the MediaPlayer. I think it makes more sense to check USE(GSTREAMER) so that ports willing to use the GStreamer based mediaplayer can explictly enable the define variable.
Attachments
proposed patch (15.94 KB, patch)
2010-09-28 06:45 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
updated patch (works with --no-video build too) (16.94 KB, patch)
2010-09-28 07:52 PDT, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-09-28 06:45:04 PDT
Created attachment 69040 [details] proposed patch
Martin Robinson
Comment 2 2010-09-28 07:31:49 PDT
Comment on attachment 69040 [details] proposed patch Okay.
Martin Robinson
Comment 3 2010-09-28 07:45:42 PDT
Comment on attachment 69040 [details] proposed patch Clearing review flag, as Philippe found another issue.
Philippe Normand
Comment 4 2010-09-28 07:52:15 PDT
Created attachment 69049 [details] updated patch (works with --no-video build too)
Martin Robinson
Comment 5 2010-09-28 08:44:10 PDT
Comment on attachment 69049 [details] updated patch (works with --no-video build too) Thanks!
Philippe Normand
Comment 6 2010-09-28 23:52:18 PDT
Committed r68632: <http://trac.webkit.org/changeset/68632>
Note You need to log in before you can comment on or make changes to this bug.