Bug 46702 - Remove unnecessary cacheFlush calls from Thumb-2
Summary: Remove unnecessary cacheFlush calls from Thumb-2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-28 00:35 PDT by Gabor Loki
Modified: 2010-09-30 01:37 PDT (History)
2 users (show)

See Also:


Attachments
Remove unnecessary cacheFlush calls from Thumb-2 (2.21 KB, patch)
2010-09-28 00:42 PDT, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-09-28 00:35:33 PDT
There are several redundant cacheFlush calls in Thumb-2 JIT.
Comment 1 Gabor Loki 2010-09-28 00:42:37 PDT
Created attachment 69029 [details]
Remove unnecessary cacheFlush calls from Thumb-2

The setPointer function calls setInt32 which calls cacheFlush on the corresponding instructions. So, there is no need for a second cacheFlush on the same address range.

SunSpider: 1.007x as fast
V8: 1.017x as fast
Comment 2 Csaba Osztrogonác 2010-09-30 01:02:02 PDT
Comment on attachment 69029 [details]
Remove unnecessary cacheFlush calls from Thumb-2

LGTM, r=me.
Comment 3 WebKit Commit Bot 2010-09-30 01:37:39 PDT
Comment on attachment 69029 [details]
Remove unnecessary cacheFlush calls from Thumb-2

Clearing flags on attachment: 69029

Committed r68764: <http://trac.webkit.org/changeset/68764>
Comment 4 WebKit Commit Bot 2010-09-30 01:37:44 PDT
All reviewed patches have been landed.  Closing bug.