FastMalloc is to allocate memory quickly. I think we need to use fast malloc as well.
Created attachment 69021 [details]
Looks good to me. However I wonder how fast it is. Does anyone have some benchmarks? Do other ports use it by default?
WebKit-GTK uses the fast malloc. However, android port, brewmp port and HAIKU port don't use it. I don't know if mac port, iphone use the fast malloc.
According to QT port guys in seged univ, fast malloc based on TCMalloc is about 2 ~ 4% faster than system malloc.
In addition, the fast malloc is good for multi-thread environment. Because, TCMalloc in the fast malloc has thread local cache per thread.
Comment on attachment 69021 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=69021&action=review
Qt, Mac, Gtk, etc. ports use TCmalloc.
> +WEBKIT_FEATURE(ENABLE_FAST_MALLOC "Enable fast memory allocation" DEFAULT ON)
It would be better to reflect the switching between system's default allocator and TCmalloc.
E.g. Enable TCmalloc instead of system's allocator
Created attachment 69166 [details]
Ok, I change the description according to your opinion. I also think that this description reflects correct information.
Hello Kenneth and Antonio,
If you are not busy, could you please review this bug?
Comment on attachment 69166 [details]
Clearing flags on attachment: 69166
Committed r69060: <http://trac.webkit.org/changeset/69060>
All reviewed patches have been landed. Closing bug.