Bug 46681 - Fix possible illegal float values in AudioParam
Summary: Fix possible illegal float values in AudioParam
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-27 17:25 PDT by Chris Rogers
Modified: 2010-09-28 10:31 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.27 KB, patch)
2010-09-27 17:27 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-09-27 17:25:40 PDT
Fix possible illegal float values in AudioParam
Comment 1 Chris Rogers 2010-09-27 17:27:54 PDT
Created attachment 68997 [details]
Patch
Comment 2 Kenneth Russell 2010-09-28 08:06:25 PDT
Comment on attachment 68997 [details]
Patch

Looks OK. I wonder about the spec text indicating that an exception is raised if the value is outside the min and max values, and about whether the value should be set to 0.0 if NaN or +/-Inf come in.
Comment 3 Chris Rogers 2010-09-28 10:09:33 PDT
I think ultimately we'll want to raise an exception (but not set the value to 0).  But for now, this is much better protection than we previously had.
Comment 4 WebKit Commit Bot 2010-09-28 10:31:42 PDT
Comment on attachment 68997 [details]
Patch

Clearing flags on attachment: 68997

Committed r68535: <http://trac.webkit.org/changeset/68535>
Comment 5 WebKit Commit Bot 2010-09-28 10:31:48 PDT
All reviewed patches have been landed.  Closing bug.