Bug 46670 - check-webkit-style should check for explicit constructors.
Summary: check-webkit-style should check for explicit constructors.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-27 16:08 PDT by David Levin
Modified: 2013-03-13 20:13 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.17 KB, patch)
2010-09-27 16:11 PDT, David Levin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2010-09-27 16:08:04 PDT 
Based on this thread: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012873.html
Comment 1 David Levin 2010-09-27 16:11:46 PDT 
Created attachment 68987 [details]
Patch
Comment 2 Darin Adler 2010-09-27 16:15:51 PDT 
Comment on attachment 68987 [details]
Patch

This doesn’t seem like a style rule to me.
Comment 3 David Levin 2010-09-27 16:24:43 PDT 
(In reply to comment #2)
> (From update of attachment 68987 [details])
> This doesn’t seem like a style rule to me.

So you don't believe that this should be flagged in general.  

I've noticed some folks noting this in reviews for patches, and in general it seems like a good practice to mark single argument constructors as explicit unless there is a good reason to do otherwise.

It seemed in keeping with this comment: https://lists.webkit.org/pipermail/webkit-dev/2010-May/012876.html

In fairness, this comment https://lists.webkit.org/pipermail/webkit-dev/2010-May/012881.html seemed to suggest a lot more modest use of explicit.
Comment 4 David Levin 2010-09-28 11:59:58 PDT 
Comment on attachment 68987 [details]
Patch

Withdrawn for now.