Bug 46665 – Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware.

[Dave Hyatt]

Created attachment 68974 [details]
Patch

[Dave Hyatt]

Created attachment 68976 [details]
Patch

[Dave Hyatt]

Created attachment 68977 [details]
Patch

[Dave Hyatt]

Created attachment 68978 [details]
Patch

[Sam Weinig]

Comment on attachment 68978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68978&action=review

> WebCore/rendering/RenderBox.cpp:1737
> -        else  {
> -            if (style()->isVerticalBlockFlow())
> -                visHeight = view()->viewHeight();
> -            else
> -                visHeight = view()->viewWidth();
> -        }
> +        else
> +            visHeight = view()->viewLogicalHeight();

I don't think this will end up using the correct style().

[Dave Hyatt]

(In reply to comment #5)
> (From update of attachment 68978 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68978&action=review
> 
> > WebCore/rendering/RenderBox.cpp:1737
> > -        else  {
> > -            if (style()->isVerticalBlockFlow())
> > -                visHeight = view()->viewHeight();
> > -            else
> > -                visHeight = view()->viewWidth();
> > -        }
> > +        else
> > +            visHeight = view()->viewLogicalHeight();
> 
> I don't think this will end up using the correct style().

Yeah I need to test more.  The code change may be correct, but it's not clear to me if stretching turns off once you encounter a directionality change.  I'll test in WinIE before patching that part.

[Dave Hyatt]

Created attachment 68982 [details]
Patch

[Dave Hyatt]

Fixed in r68436.