Bug 46665 - Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware.
Summary: Patch RenderView's layout and computeLogicalWidth/Height methods to be block-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency tree / graph
 
Reported: 2010-09-27 15:26 PDT by Dave Hyatt
Modified: 2010-09-27 15:58 PDT (History)
0 users

See Also:

Attachments
Patch (25.38 KB, patch)
2010-09-27 15:30 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (21.16 KB, text/plain)
2010-09-27 15:33 PDT, Dave Hyatt 		no flags Details
Patch (21.16 KB, patch)
2010-09-27 15:34 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (21.13 KB, patch)
2010-09-27 15:35 PDT, Dave Hyatt 		sam: review-
Details | Formatted Diff | Diff
Patch (20.21 KB, patch)
2010-09-27 15:54 PDT, Dave Hyatt 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-09-27 15:26:37 PDT 
Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware.
Comment 1 Dave Hyatt 2010-09-27 15:30:10 PDT 
Created attachment 68974 [details]
Patch
Comment 2 Dave Hyatt 2010-09-27 15:33:55 PDT 
Created attachment 68976 [details]
Patch
Comment 3 Dave Hyatt 2010-09-27 15:34:37 PDT 
Created attachment 68977 [details]
Patch
Comment 4 Dave Hyatt 2010-09-27 15:35:28 PDT 
Created attachment 68978 [details]
Patch
Comment 5 Sam Weinig 2010-09-27 15:52:22 PDT 
Comment on attachment 68978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68978&action=review

> WebCore/rendering/RenderBox.cpp:1737
> -        else  {
> -            if (style()->isVerticalBlockFlow())
> -                visHeight = view()->viewHeight();
> -            else
> -                visHeight = view()->viewWidth();
> -        }
> +        else
> +            visHeight = view()->viewLogicalHeight();

I don't think this will end up using the correct style().
Comment 6 Dave Hyatt 2010-09-27 15:54:28 PDT 
(In reply to comment #5)
> (From update of attachment 68978 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68978&action=review
> 
> > WebCore/rendering/RenderBox.cpp:1737
> > -        else  {
> > -            if (style()->isVerticalBlockFlow())
> > -                visHeight = view()->viewHeight();
> > -            else
> > -                visHeight = view()->viewWidth();
> > -        }
> > +        else
> > +            visHeight = view()->viewLogicalHeight();
> 
> I don't think this will end up using the correct style().

Yeah I need to test more.  The code change may be correct, but it's not clear to me if stretching turns off once you encounter a directionality change.  I'll test in WinIE before patching that part.
Comment 7 Dave Hyatt 2010-09-27 15:54:58 PDT 
Created attachment 68982 [details]
Patch
Comment 8 Dave Hyatt 2010-09-27 15:58:52 PDT 
Fixed in r68436.