webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console Should use OutputCapture instead. See outputcapture.py (or other unittest examples. test_prompt_with_list (webkitpy.common.system.user_unittest.UserTest) ... title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar title 1. foo 2. bar ok
Created attachment 68935 [details] Patch
Comment on attachment 68935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68935&action=review > WebKitTools/Scripts/webkitpy/common/system/user_unittest.py:56 > + # Don't care about output. Why not assert that the output is correct?
Comment on attachment 68935 [details] Patch Seems OK. We could care about the output. assert_outputs will return the value of the function it calls. The comment should probably say "Other tests cover output, this test only checks parsing behavior" or similar. I guess I should implement __enter__ and __exit__ for OutputCapture so we can use it with "with"
Created attachment 68938 [details] Patch
Comment on attachment 68938 [details] Patch LGTM! THanks.
Comment on attachment 68938 [details] Patch Rejecting patch 68938 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68938]" exit_code: 2 Cleaning working directory Updating working directory Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4131015
Comment on attachment 68938 [details] Patch Clearing flags on attachment: 68938 Committed r68432: <http://trac.webkit.org/changeset/68432>
All reviewed patches have been landed. Closing bug.