Bug 46633 - WebKit2: allow debug opt-out from sandbox via default
Summary: WebKit2: allow debug opt-out from sandbox via default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-27 11:04 PDT by Ivan Krstić
Modified: 2010-09-27 15:10 PDT (History)
0 users

See Also:

Attachments
Allow disabling WebKit2 sandbox on Mac (1.91 KB, patch)
2010-09-27 11:04 PDT, Ivan Krstić 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Krstić 2010-09-27 11:04:58 PDT 
Created attachment 68933 [details]
Allow disabling WebKit2 sandbox on Mac

The attached patch introduces a new debugging default, com.apple.WebProcess.DisableSandbox, which can be used to disable the WebKit2 sandbox on the Mac.
Comment 1 Mark Rowe (bdash) 2010-09-27 13:13:01 PDT 
Comment on attachment 68933 [details]
Allow disabling WebKit2 sandbox on Mac

View in context: https://bugs.webkit.org/attachment.cgi?id=68933&action=review

> WebProcess/mac/WebProcessMainMac.mm:75
> +    } else {
> +        fprintf(stderr, "WebProcess: bypassing sandbox due to com.apple.WebProcess.DisableSandbox default; behavior will differ from production builds\n");
>      }

The braces around this “else” are unnecessary and should be removed.  I think it would be preferable to use NSLog here rather than printf.  I will make those changes when landing this patch.
Comment 2 Mark Rowe (bdash) 2010-09-27 15:10:20 PDT 
Landed in r68429.