WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46633
WebKit2: allow debug opt-out from sandbox via default
https://bugs.webkit.org/show_bug.cgi?id=46633
Summary
WebKit2: allow debug opt-out from sandbox via default
Ivan Krstić
Reported
2010-09-27 11:04:58 PDT
Created
attachment 68933
[details]
Allow disabling WebKit2 sandbox on Mac The attached patch introduces a new debugging default, com.apple.WebProcess.DisableSandbox, which can be used to disable the WebKit2 sandbox on the Mac.
Attachments
Allow disabling WebKit2 sandbox on Mac
(1.91 KB, patch)
2010-09-27 11:04 PDT
,
Ivan Krstić
mrowe
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2010-09-27 13:13:01 PDT
Comment on
attachment 68933
[details]
Allow disabling WebKit2 sandbox on Mac View in context:
https://bugs.webkit.org/attachment.cgi?id=68933&action=review
> WebProcess/mac/WebProcessMainMac.mm:75 > + } else { > + fprintf(stderr, "WebProcess: bypassing sandbox due to com.apple.WebProcess.DisableSandbox default; behavior will differ from production builds\n"); > }
The braces around this “else” are unnecessary and should be removed. I think it would be preferable to use NSLog here rather than printf. I will make those changes when landing this patch.
Mark Rowe (bdash)
Comment 2
2010-09-27 15:10:20 PDT
Landed in
r68429
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug