Changeset http://trac.webkit.org/changeset/68357 revealed an incremental build issue: if headers are moved the script does not regenerate the corresponding forwarding headers. Make generate-forwarding-headers.pl more robust by checking the content of existing forwarding headers and regenerating them if they do not contain what's expected.
Created attachment 68907 [details] proposed patch
Comment on attachment 68907 [details] proposed patch It will make WebKit2 build system more robust without any needless forwarding header regeneration and performace regression. Great fix, r=me.
Comment on attachment 68907 [details] proposed patch Rejecting patch 68907 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68907]" exit_code: 2 Cleaning working directory Updating working directory Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4074123
Comment on attachment 68907 [details] proposed patch Clearing flags on attachment: 68907 Committed r68409: <http://trac.webkit.org/changeset/68409>
All reviewed patches have been landed. Closing bug.
False rejection. Bug in the queue. One of the cluster nodes seems stuck.
(In reply to comment #4) > (From update of attachment 68907 [details]) > Clearing flags on attachment: 68907 > > Committed r68409: <http://trac.webkit.org/changeset/68409> Thanks, Ossy for landing it.