Bug 46618 - [Qt] : Enable local rendering on Maemo6
Summary: [Qt] : Enable local rendering on Maemo6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-09-27 06:08 PDT by Girish Ramakrishnan
Modified: 2010-09-27 11:37 PDT (History)
3 users (show)

See Also:

Attachments
Enable local rendering on Maemo6 (7.77 KB, patch)
2010-09-27 06:11 PDT, Girish Ramakrishnan 		no flags Details | Formatted Diff | Diff
Enable local rendering on Maemo6 take 2 (7.61 KB, patch)
2010-09-27 06:26 PDT, Girish Ramakrishnan 		tonikitoo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Girish Ramakrishnan 2010-09-27 06:08:43 PDT 
Enable local rendering on Maemo6.
Comment 1 Girish Ramakrishnan 2010-09-27 06:11:40 PDT 
Created attachment 68900 [details]
Enable local rendering on Maemo6
Comment 2 WebKit Review Bot 2010-09-27 06:12:20 PDT 
Attachment 68900 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/plugins/qt/PluginViewQt.cpp:77:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Girish Ramakrishnan 2010-09-27 06:26:27 PDT 
Created attachment 68902 [details]
Enable local rendering on Maemo6 take 2

Remove unnecessary include
Comment 4 Antonio Gomes 2010-09-27 06:36:57 PDT 
Comment on attachment 68902 [details]
Enable local rendering on Maemo6 take 2

You could had mentioned "plugins" in the description. Maybe "enable local rendering of plugins" or whatever more specific, since the changelog is not detailed.
Comment 5 Antonio Gomes 2010-09-27 06:37:15 PDT 
Comment on attachment 68902 [details]
Enable local rendering on Maemo6 take 2

I meant r+
Comment 6 Early Warning System Bot 2010-09-27 06:44:55 PDT 
Attachment 68900 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4093082
Comment 7 Girish Ramakrishnan 2010-09-27 07:55:03 PDT 
Landed in r68390
Comment 8 Ademar Reis 2010-09-27 11:36:56 PDT 
Revision r68390 cherry-picked into qtwebkit-2.1 with commit eda6059 <http://gitorious.org/webkit/qtwebkit/commit/eda6059>