Bug 46611 - Web Inspector: split InspectorTimelineAgent into two parts.
Summary: Web Inspector: split InspectorTimelineAgent into two parts.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on: 46637
Blocks: 46614
  Show dependency treegraph
 
Reported: 2010-09-27 01:25 PDT by Ilya Tikhonovsky
Modified: 2010-09-27 11:35 PDT (History)
10 users (show)

See Also:


Attachments
[patch] initial version. (25.50 KB, patch)
2010-09-27 01:27 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] second iteration (26.55 KB, patch)
2010-09-27 03:23 PDT, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-09-27 01:25:42 PDT
We have an idea to split InspectorTimelineAgent into two parts.
The first part is an instrumentation API which can be used for DOM breakpoints too.
The other is the real Timeline agent which do a transformation of raw data into timeline data.
Comment 1 Ilya Tikhonovsky 2010-09-27 01:27:36 PDT
Created attachment 68886 [details]
[patch] initial version.
Comment 2 Ilya Tikhonovsky 2010-09-27 01:30:38 PDT
this is the first patch for that.
In the next patches I'll rename API part of Timeline Agent to InspectorInstrumentation and fix all Timeline related places in WebCore.
Comment 3 WebKit Review Bot 2010-09-27 01:34:31 PDT
Attachment 68886 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/InspectorTimelineAgent.cpp:50:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Pavel Feldman 2010-09-27 01:41:39 PDT
It would be great to post the entire plan here. I agree that it might be worth doing more than a single patch, but we need a meta-bug to track it.
Comment 5 Ilya Tikhonovsky 2010-09-27 03:23:10 PDT
Created attachment 68895 [details]
[patch] second iteration

style was fixed.
meta-bug was created.
Comment 6 Pavel Feldman 2010-09-27 05:56:51 PDT
Comment on attachment 68895 [details]
[patch] second iteration

View in context: https://bugs.webkit.org/attachment.cgi?id=68895&action=review

> WebCore/inspector/InspectorTimelineAgent.cpp:49
> +class InspectorTimelineAgent2 : ScriptGCEventListener, public Noncopyable {

I'd rather call this one InspectorTimeline (leave the name) + Call new one InspectorInstrumentation.

> WebCore/inspector/InspectorTimelineAgent.cpp:67
> +        : record(record), data(data), children(children), type(type)

Use WebKit indentation.

> WebCore/inspector/InspectorTimelineAgent.cpp:79
> +        : startTime(startTime), endTime(endTime), collectedBytes(collectedBytes)

ditto
Comment 7 Ilya Tikhonovsky 2010-09-27 07:00:19 PDT
Committed r68389
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.h
r68389 = 61bf1b14bdab882b955c90734e98974872476198 (refs/remotes/trunk)