Bug 46611 – Web Inspector: split InspectorTimelineAgent into two parts.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

We have an idea to split InspectorTimelineAgent into two parts.
The first part is an instrumentation API which can be used for DOM breakpoints too.
The other is the real Timeline agent which do a transformation of raw data into timeline data.

[Ilya Tikhonovsky]

Created attachment 68886 [details]
[patch] initial version.

[Ilya Tikhonovsky]

this is the first patch for that.
In the next patches I'll rename API part of Timeline Agent to InspectorInstrumentation and fix all Timeline related places in WebCore.

[WebKit Review Bot]

Attachment 68886 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/InspectorTimelineAgent.cpp:50:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Feldman]

It would be great to post the entire plan here. I agree that it might be worth doing more than a single patch, but we need a meta-bug to track it.

[Ilya Tikhonovsky]

Created attachment 68895 [details]
[patch] second iteration

style was fixed.
meta-bug was created.

[Pavel Feldman]

Comment on attachment 68895 [details]
[patch] second iteration

View in context: https://bugs.webkit.org/attachment.cgi?id=68895&action=review

> WebCore/inspector/InspectorTimelineAgent.cpp:49
> +class InspectorTimelineAgent2 : ScriptGCEventListener, public Noncopyable {

I'd rather call this one InspectorTimeline (leave the name) + Call new one InspectorInstrumentation.

> WebCore/inspector/InspectorTimelineAgent.cpp:67
> +        : record(record), data(data), children(children), type(type)

Use WebKit indentation.

> WebCore/inspector/InspectorTimelineAgent.cpp:79
> +        : startTime(startTime), endTime(endTime), collectedBytes(collectedBytes)

ditto

[Ilya Tikhonovsky]

Committed r68389
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.h
r68389 = 61bf1b14bdab882b955c90734e98974872476198 (refs/remotes/trunk)