Bug 46605 – Add method which checks if a WebAccessibilityObject is in the cache.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Chris Guillory]

In chromium notifications code we need a way to determine if our WebAccessibilityCache currently contains a mapping for a WebAccessibilityObject.

This will help to resolve a Chromium bug.
http://code.google.com/p/chromium/issues/detail?id=46209

[Chris Guillory]

Created attachment 68875 [details]
Add WebAccessibilityCache::isCached

[Adam Barth]

+fishd for Chromium API change.

[Dimitri Glazkov (Google)]

Comment on attachment 68875 [details]
Add WebAccessibilityCache::isCached

What's the wider context of the change here? I really think we should keep caching invisible to the embedding layer.

[Chris Guillory]

This is for an issue in Chromium.
http://code.google.com/p/chromium/issues/detail?id=46209

Within the renderer WebAccessibilityObject instances are added to WebAccessibilityCacheImpl's cache before they are sent to the browser. The issue is that the browser cannot process a notification for a WebAccessibilityObject that isn't in this cache.

AXObjectCache has
// to be used with render objects
AccessibilityObject* getOrCreate(RenderObject*);

// will only return the AccessibilityObject if it already exists
AccessibilityObject* get(RenderObject*);

This is an attempt to add a method similar to AXObjectCache::get.

[Chris Guillory]

Created attachment 69087 [details]
Add WebAccessibilityCache:getId

How about I add the method as getId. It will return invalidId when the WebAccessibilityCache doesn't have an id mapping for the AccessibilityObject.

[WebKit Review Bot]

Attachment 69087 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4165003

[Chris Guillory]

Created attachment 69113 [details]
Add WebAccessibilityCache:getId - Now compiles

Corrected return type in header.

[Dimitri Glazkov (Google)]

Comment on attachment 69113 [details]
Add WebAccessibilityCache:getId - Now compiles

I neglected to see that this is dealing with our WebKit-layer cache, not AXObjectCache. Thus I (and Darin) like the initial version of the patch.

[WebKit Commit Bot]

Comment on attachment 68875 [details]
Add WebAccessibilityCache::isCached

Clearing flags on attachment: 68875

Committed r68658: <http://trac.webkit.org/changeset/68658>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.