Bug 46561 - Add create method to FileSystemCallbacks to get rid of naked new's
Summary: Add create method to FileSystemCallbacks to get rid of naked new's
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-25 02:50 PDT by Kinuko Yasuda
Modified: 2010-09-27 12:05 PDT (History)
3 users (show)

See Also:


Attachments
Patch (24.76 KB, patch)
2010-09-25 02:55 PDT, Kinuko Yasuda
no flags Details | Formatted Diff | Diff
Patch (24.59 KB, patch)
2010-09-25 03:23 PDT, Kinuko Yasuda
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-09-25 02:50:05 PDT
Add create method to FileSystemCallbacks to get rid of naked new's.

Also cleanup the callbacks layering to pass AsyncFileSystemCallbacks object to LocalFileSystem::requestFileSystem (rather than FileSystemCallback and ErrorCallback)
so that all the callbacks class we pass from WebCore to WebKit/chromium/src will be AsyncFileSystemCallbacks.
Comment 1 Kinuko Yasuda 2010-09-25 02:55:23 PDT
Created attachment 68820 [details]
Patch
Comment 2 Kinuko Yasuda 2010-09-25 03:23:27 PDT
Created attachment 68821 [details]
Patch
Comment 3 Alexey Proskuryakov 2010-09-26 00:40:27 PDT
Changed summary: we usually put platform in brackets for platform-only patches. Some people who are only interested in cross-platform work have customized queries to ignore such.
Comment 4 Adam Barth 2010-09-26 21:17:53 PDT
Comment on attachment 68821 [details]
Patch

Love it.
Comment 5 Kinuko Yasuda 2010-09-27 12:05:24 PDT
Committed r68411: <http://trac.webkit.org/changeset/68411>