RESOLVED FIXED 46561
Add create method to FileSystemCallbacks to get rid of naked new's 
https://bugs.webkit.org/show_bug.cgi?id=46561
Summary Add create method to FileSystemCallbacks to get rid of naked new's
Kinuko Yasuda
Reported 2010-09-25 02:50:05 PDT
Add create method to FileSystemCallbacks to get rid of naked new's. Also cleanup the callbacks layering to pass AsyncFileSystemCallbacks object to LocalFileSystem::requestFileSystem (rather than FileSystemCallback and ErrorCallback) so that all the callbacks class we pass from WebCore to WebKit/chromium/src will be AsyncFileSystemCallbacks.
Attachments
Patch (24.76 KB, patch)
2010-09-25 02:55 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (24.59 KB, patch)
2010-09-25 03:23 PDT, Kinuko Yasuda 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2010-09-25 02:55:23 PDT
Created attachment 68820 [details] Patch
Kinuko Yasuda
Comment 2 2010-09-25 03:23:27 PDT
Created attachment 68821 [details] Patch
Alexey Proskuryakov
Comment 3 2010-09-26 00:40:27 PDT
Changed summary: we usually put platform in brackets for platform-only patches. Some people who are only interested in cross-platform work have customized queries to ignore such.
Adam Barth
Comment 4 2010-09-26 21:17:53 PDT
Comment on attachment 68821 [details] Patch Love it.
Kinuko Yasuda
Comment 5 2010-09-27 12:05:24 PDT
Committed r68411: <http://trac.webkit.org/changeset/68411>
Note You need to log in before you can comment on or make changes to this bug.