Bug 46557 - [Chromium] animations/opacity-transform-animation.html fails on Chromium
Summary: [Chromium] animations/opacity-transform-animation.html fails on Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-24 23:51 PDT by Mihai Parparita
Modified: 2010-09-28 18:38 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.28 KB, patch)
2010-09-27 23:28 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff
Patch (7.60 KB, patch)
2010-09-28 00:10 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff
Patch (3.82 KB, patch)
2010-09-28 18:11 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-09-24 23:51:05 PDT
The test was added in http://trac.webkit.org/changeset/68323, and it's been getting image diffs since then. The animation is subtle enough (going from opacity .8 to .9) that I'm not sure if it's just a slight color difference in Chromium or an actual behavior difference.
Comment 1 Mihai Parparita 2010-09-27 23:28:31 PDT
Created attachment 69024 [details]
Patch
Comment 2 Mihai Parparita 2010-09-27 23:30:36 PDT
Not 100% sure why the more subtle opacity change caused image diffs with the Chromium DRT (precision issues?), but since the intent of the test is to test two properties changing (not image fidelity), it still seems valid with this change.
Comment 3 Mihai Parparita 2010-09-27 23:41:42 PDT
Comment on attachment 69024 [details]
Patch

Nevermind about this patch, I wasn't actually passing --chromium to NRWT, which is why this test was passing with these baselines.
Comment 4 Mihai Parparita 2010-09-28 00:09:12 PDT
Actually, it seems to be the Mac port that has the precision issues. At the point where the pixel dump is done, the moving box has opacity of 0.5. I would expect the color on the screen to be (0*.5 + 255 * .5, 128 * .5 + 0 * 0.5, 0 * .5 + 0 * 0.5) = (128, 64, 0). However, the Mac port sees (125, 89, 7). Is this color correction in action?
Comment 5 Mihai Parparita 2010-09-28 00:10:39 PDT
Created attachment 69027 [details]
Patch
Comment 6 Simon Fraser (smfr) 2010-09-28 11:36:50 PDT
Comment on attachment 69027 [details]
Patch

We prefer to keep green boxes indicating success. The almost-red box in the result here communicates failure.

Maybe it would be better not to use a red background square, but to have a box which surrounds the success location.
Comment 7 Mihai Parparita 2010-09-28 18:11:13 PDT
Created attachment 69147 [details]
Patch
Comment 8 Mihai Parparita 2010-09-28 18:12:24 PDT
Actually, I don't have to touch the Mac baselines at all if I make the opacity transition go from 0.7 to 1.0 (like the latest patch). Is that OK?
Comment 9 WebKit Commit Bot 2010-09-28 18:37:57 PDT
Comment on attachment 69147 [details]
Patch

Clearing flags on attachment: 69147

Committed r68619: <http://trac.webkit.org/changeset/68619>
Comment 10 WebKit Commit Bot 2010-09-28 18:38:02 PDT
All reviewed patches have been landed.  Closing bug.