Bug 46548 - [Qt] GraphicsContext::setLineDash() should scale dashOffset to penWidth
Summary: [Qt] GraphicsContext::setLineDash() should scale dashOffset to penWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://www.carto.net/svg/samples/anim...
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-09-24 20:12 PDT by Andreas Kling
Modified: 2010-09-25 09:25 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch (1.35 KB, patch)
2010-09-24 20:16 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-09-24 20:12:38 PDT 
Qt's setLineDash() currently scales the dash array to the painter's penWidth, but not the dashOffset.

This causes incorrect rendering of http://www.carto.net/svg/samples/animated_bustrack.shtml

The problem is also exposed by (at least) one in-tree layout test:
- svg/custom/js-repaint-rect-on-path-with-stroke.svg
Comment 1 Andreas Kling 2010-09-24 20:16:25 PDT 
Created attachment 68805 [details]
Proposed patch
Comment 2 Andreas Kling 2010-09-25 08:44:26 PDT 
Comment on attachment 68805 [details]
Proposed patch

Clearing flags on attachment: 68805

Committed r68331: <http://trac.webkit.org/changeset/68331>
Comment 3 Andreas Kling 2010-09-25 08:44:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-09-25 09:10:39 PDT 
http://trac.webkit.org/changeset/68331 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/68329
http://trac.webkit.org/changeset/68330
http://trac.webkit.org/changeset/68331
Comment 5 Andreas Kling 2010-09-25 09:25:28 PDT 
(In reply to comment #4)
> http://trac.webkit.org/changeset/68331 might have totally b0rken Qt Linux Release

Fixed with <http://trac.webkit.org/changeset/68332> :)