Bug 46546 – Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:].

[Sam Weinig]

<rdar://problem/8359279>

[Sam Weinig]

Created attachment 68797 [details]
Patch

[WebKit Review Bot]

Attachment 68797 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKPage.h:167:  Extra space between WKPageMouseDidMoveOverElementCallback and mouseDidMoveOverElement  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:132:  Extra space between WKBundlePageMouseDidMoveOverElementCallback and mouseDidMoveOverElement  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:55:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:64:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:68:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 8 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Attachment 68797 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4033141

[Sam Weinig]

Fixed Qt build locally.

[Darin Adler]

Comment on attachment 68797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68797&action=review

Looks like you broke Qt. If you deal with that, r=me.

> WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:43
> +    RefPtr<InjectedBundleNodeHandle> nodeHandle = toWK(hitTestResultRef)->nodeHandle();
> +    return toRef(nodeHandle.get());

Do you need a local variable here?

[Sam Weinig]

Landed in http://trac.webkit.org/changeset/68322.