Bug 46545 - dump-as-markup conversion: editing/pasteboard/paste-4039777-fix.html, paste-list-001.html, and paste-table-001.html
Summary: dump-as-markup conversion: editing/pasteboard/paste-4039777-fix.html, paste-l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 34564
  Show dependency treegraph
 
Reported: 2010-09-24 18:20 PDT by Ryosuke Niwa
Modified: 2010-09-28 10:33 PDT (History)
6 users (show)

See Also:


Attachments
Patch (91.27 KB, patch)
2010-09-24 18:30 PDT, Ryosuke Niwa
tkent: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-09-24 18:20:26 PDT
The following two tests should be converted to dump-as-markup tests because they are testing copying & pasting generates the desired DOM:
editing/pasteboard/paste-4039777-fix.html
editing/pasteboard/paste-list-001.html
editing/pasteboard/paste-table-001.html
Comment 1 Ryosuke Niwa 2010-09-24 18:30:52 PDT
Created attachment 68798 [details]
Patch
Comment 2 Kent Tamura 2010-09-26 18:13:44 PDT
Comment on attachment 68798 [details]
Patch

Looks good!
Comment 3 Ryosuke Niwa 2010-09-27 10:21:34 PDT
(In reply to comment #2)
> (From update of attachment 68798 [details])
> Looks good!

Thanks for the review.
Comment 4 WebKit Commit Bot 2010-09-27 11:23:05 PDT
Comment on attachment 68798 [details]
Patch

Rejecting patch 68798 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68798]" exit_code: 2
Cleaning working directory
Updating working directory
Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2

Full output: http://queues.webkit.org/results/4079121
Comment 5 WebKit Commit Bot 2010-09-27 12:24:24 PDT
Comment on attachment 68798 [details]
Patch

Rejecting patch 68798 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68798]" exit_code: 2
Cleaning working directory
Updating working directory
Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2

Full output: http://queues.webkit.org/results/4132015
Comment 6 Ryosuke Niwa 2010-09-28 10:33:31 PDT
Committed r68536: <http://trac.webkit.org/changeset/68536>