RESOLVED FIXED 46537
SVG: Avoid calling pow() in genericParseNumber() unless necessary 
https://bugs.webkit.org/show_bug.cgi?id=46537
Summary SVG: Avoid calling pow() in genericParseNumber() unless necessary
Andreas Kling
Reported 2010-09-24 16:26:49 PDT
We don't need to call pow() if there's no exponent. 0.4% speedup on <http://themaninblue.com/experiment/AnimationBenchmark/svg/>
Attachments
Proposed patch (1.24 KB, patch)
2010-09-24 16:28 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-09-24 16:28:13 PDT
Created attachment 68787 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-09-24 16:36:58 PDT
Comment on attachment 68787 [details] Proposed patch Nice !
WebKit Commit Bot
Comment 3 2010-09-24 18:57:24 PDT
Comment on attachment 68787 [details] Proposed patch Clearing flags on attachment: 68787 Committed r68321: <http://trac.webkit.org/changeset/68321>
WebKit Commit Bot
Comment 4 2010-09-24 18:57:29 PDT
All reviewed patches have been landed. Closing bug.
Matthew Delaney
Comment 5 2010-09-26 10:37:01 PDT
Just out of curiosity, how were you able to accurately/reliably measure a 0.4% speedup? Did you instrument the fps meter from that test to display some sort of longer run - and thus more steady - average?
Andreas Kling
Comment 6 2010-09-26 10:46:56 PDT
(In reply to comment #5) > Just out of curiosity, how were you able to accurately/reliably measure a 0.4% speedup? Did you instrument the fps meter from that test to display some sort of longer run - and thus more steady - average? Using an internal tool that runs something for X frames and measures wall/CPU time spent. Also, testing on a slow device helps a lot with the stability of timings.
Note You need to log in before you can comment on or make changes to this bug.