Bug 46533 - Add HighPass2FilterNode files
Summary: Add HighPass2FilterNode files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-24 15:40 PDT by Chris Rogers
Modified: 2010-10-05 00:33 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.86 KB, patch)
2010-09-24 15:41 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (7.26 KB, patch)
2010-10-04 14:52 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (7.25 KB, patch)
2010-10-04 15:29 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-09-24 15:40:54 PDT 
Add HighPass2FilterNode files
Comment 1 Chris Rogers 2010-09-24 15:41:51 PDT 
Created attachment 68775 [details]
Patch
Comment 2 Chris Rogers 2010-10-04 14:52:13 PDT 
Created attachment 69691 [details]
Patch
Comment 3 Chris Rogers 2010-10-04 14:53:32 PDT 
Fixed license and added FIXME in .idl about moving to BiquadNode.
Comment 4 Kenneth Russell 2010-10-04 15:00:28 PDT 
Comment on attachment 69691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69691&action=review

> WebCore/webaudio/HighPass2FilterNode.cpp:38
> +    m_processor = biquadProcessor.release();

Please see LowPass2FilterNode for request about the disposition of the m_biquadProcessor member.
Comment 5 Chris Rogers 2010-10-04 15:29:05 PDT 
Created attachment 69699 [details]
Patch
Comment 6 Chris Rogers 2010-10-04 15:30:20 PDT 
FIXED: Addressed comments about m_biquadProcessor as in LowPass2FilterNode.
Comment 7 Kenneth Russell 2010-10-04 15:50:01 PDT 
Comment on attachment 69699 [details]
Patch

Looks good to me.
Comment 8 WebKit Commit Bot 2010-10-05 00:33:28 PDT 
Comment on attachment 69699 [details]
Patch

Clearing flags on attachment: 69699

Committed r69088: <http://trac.webkit.org/changeset/69088>
Comment 9 WebKit Commit Bot 2010-10-05 00:33:35 PDT 
All reviewed patches have been landed.  Closing bug.