RESOLVED FIXED 46528
Add BiquadDSPKernel files 
https://bugs.webkit.org/show_bug.cgi?id=46528
Summary Add BiquadDSPKernel files
Chris Rogers
Reported 2010-09-24 15:26:58 PDT
Add BiquadDSPKernel files
Attachments
Patch (6.96 KB, patch)
2010-09-24 15:28 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (6.52 KB, patch)
2010-10-04 17:11 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (6.59 KB, patch)
2010-10-04 17:16 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-09-24 15:28:10 PDT
Created attachment 68770 [details] Patch
Kenneth Russell
Comment 2 2010-10-04 15:07:38 PDT
Comment on attachment 68770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68770&action=review Code generally looks good; one change, plus please update the copyright notice. > WebCore/webaudio/BiquadDSPKernel.h:56 > + BiquadProcessor* m_biquadProcessor; Please remove this weak pointer and instead provide a helper method which downcasts the superclass's pointer. Having multiple pointers in multiple classes all pointing to the same storage makes understanding the lifetime difficult. Also, the superclass doesn't maintain an OwnPtr; who actually owns the AudioDSPKernelProcessor* in the superclass?
Chris Rogers
Comment 3 2010-10-04 17:11:08 PDT
Created attachment 69723 [details] Patch
Chris Rogers
Comment 4 2010-10-04 17:16:41 PDT
Created attachment 69724 [details] Patch
Chris Rogers
Comment 5 2010-10-04 17:17:27 PDT
Updated LICENSE and added biquadProcessor() method as suggested.
Kenneth Russell
Comment 6 2010-10-04 17:19:25 PDT
Comment on attachment 69724 [details] Patch Looks good to me.
WebKit Commit Bot
Comment 7 2010-10-05 01:27:31 PDT
Comment on attachment 69724 [details] Patch Clearing flags on attachment: 69724 Committed r69095: <http://trac.webkit.org/changeset/69095>
WebKit Commit Bot
Comment 8 2010-10-05 01:27:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.