Bug 46513 - REGRESSION (r68054): Buttons no longer render at correct sizes
Summary: REGRESSION (r68054): Buttons no longer render at correct sizes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Darin Adler
URL: data:text/html,%3Cinput%20type=%22sub...
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2010-09-24 14:23 PDT by Mark Rowe (bdash)
Modified: 2010-09-27 17:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (141.20 KB, patch)
2010-09-27 17:11 PDT, Darin Adler 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2010-09-24 14:23:22 PDT 
After <http://trac.webkit.org/changeset/68054> it looks as though some amount of state is not being reset between the handling of independent buttons.  Typically buttons expressed as <input type="submit" style="font-size: 10px”> render at a shorter height.  If it’s on a page following a regular sized button you’ll see that its rendering at the wrong height.
Comment 1 Mark Rowe (bdash) 2010-09-24 14:24:16 PDT 
<rdar://problem/8476536>
Comment 2 Darin Adler 2010-09-24 18:33:48 PDT 
One thing I noticed in http://trac.webkit.org/changeset/68054 is that I got the logic backwards in this expression: "((states & DefaultState) ? nonDefaultButton : defaultButton)". But I don’t see anything else yet.
Comment 3 Darin Adler 2010-09-27 17:11:00 PDT 
Created attachment 68994 [details]
Patch
Comment 4 Darin Adler 2010-09-27 17:40:27 PDT 
Committed r68459: <http://trac.webkit.org/changeset/68459>
Comment 5 WebKit Review Bot 2010-09-27 17:48:21 PDT 
http://trac.webkit.org/changeset/68459 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/68459
http://trac.webkit.org/changeset/68460