Bug 46511 - Support emit_op_mod() for MIPS on JSVALUE32_64
Summary: Support emit_op_mod() for MIPS on JSVALUE32_64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-24 14:19 PDT by Chao-ying Fu
Modified: 2010-10-27 18:30 PDT (History)
1 user (show)

See Also:


Attachments
Use MIPS div for op_mod on JSVALUE32_64 (4.47 KB, patch)
2010-09-24 14:29 PDT, Chao-ying Fu
oliver: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Resolve conflicts (4.44 KB, patch)
2010-10-27 13:46 PDT, Chao-ying Fu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chao-ying Fu 2010-09-24 14:19:35 PDT
Hi All,

  I will post a patch to support emit_op_mod for MIPS on JSVALUE32_64.  Thanks!

Regards,
Chao-ying
Comment 1 Chao-ying Fu 2010-09-24 14:29:03 PDT
Created attachment 68750 [details]
Use MIPS div for op_mod on JSVALUE32_64

This patch for JITArithmetic32_64.cpp is similar to the earlier patch for JITArithmetic.cpp.  It uses MIPS div instructions for emit_op_mod().  The testing is ok on MIPS.  Thanks!

Ex:
0 regressions found.
0 tests fixed.
OK.
Comment 2 Oliver Hunt 2010-10-27 13:24:00 PDT
Comment on attachment 68750 [details]
Use MIPS div for op_mod on JSVALUE32_64

r=me
Comment 3 WebKit Commit Bot 2010-10-27 13:33:14 PDT
Comment on attachment 68750 [details]
Use MIPS div for op_mod on JSVALUE32_64

Rejecting patch 68750 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 68750]" exit_code: 2
Last 500 characters of output:
tTools/Scripts/svn-apply', u'--reviewer', u'Oliver Hunt', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file JavaScriptCore/jit/JITArithmetic32_64.cpp
Hunk #2 FAILED at 1301.
1 out of 3 hunks FAILED -- saving rejects to file JavaScriptCore/jit/JITArithmetic32_64.cpp.rej

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Oliver Hunt', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4831046
Comment 4 Chao-ying Fu 2010-10-27 13:46:52 PDT
Created attachment 72082 [details]
Resolve conflicts

Here is the new patch that resolves conflicts from merging.

Regards,
Chao-ying
Comment 5 WebKit Commit Bot 2010-10-27 18:30:18 PDT
Comment on attachment 72082 [details]
Resolve conflicts

Clearing flags on attachment: 72082

Committed r70736: <http://trac.webkit.org/changeset/70736>
Comment 6 WebKit Commit Bot 2010-10-27 18:30:26 PDT
All reviewed patches have been landed.  Closing bug.