Bug 46511 – Support emit_op_mod() for MIPS on JSVALUE32_64

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Chao-ying Fu]

Hi All,

  I will post a patch to support emit_op_mod for MIPS on JSVALUE32_64.  Thanks!

Regards,
Chao-ying

[Chao-ying Fu]

Created attachment 68750 [details]
Use MIPS div for op_mod on JSVALUE32_64

This patch for JITArithmetic32_64.cpp is similar to the earlier patch for JITArithmetic.cpp.  It uses MIPS div instructions for emit_op_mod().  The testing is ok on MIPS.  Thanks!

Ex:
0 regressions found.
0 tests fixed.
OK.

[Oliver Hunt]

Comment on attachment 68750 [details]
Use MIPS div for op_mod on JSVALUE32_64

r=me

[WebKit Commit Bot]

Comment on attachment 68750 [details]
Use MIPS div for op_mod on JSVALUE32_64

Rejecting patch 68750 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 68750]" exit_code: 2
Last 500 characters of output:
tTools/Scripts/svn-apply', u'--reviewer', u'Oliver Hunt', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file JavaScriptCore/jit/JITArithmetic32_64.cpp
Hunk #2 FAILED at 1301.
1 out of 3 hunks FAILED -- saving rejects to file JavaScriptCore/jit/JITArithmetic32_64.cpp.rej

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Oliver Hunt', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4831046

[Chao-ying Fu]

Created attachment 72082 [details]
Resolve conflicts

Here is the new patch that resolves conflicts from merging.

Regards,
Chao-ying

[WebKit Commit Bot]

Comment on attachment 72082 [details]
Resolve conflicts

Clearing flags on attachment: 72082

Committed r70736: <http://trac.webkit.org/changeset/70736>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.