Bug 46495 - Add AudioBasicProcessorNode files
Summary: Add AudioBasicProcessorNode files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-24 12:16 PDT by Chris Rogers
Modified: 2010-10-05 23:14 PDT (History)
9 users (show)

See Also:


Attachments
Patch (9.73 KB, patch)
2010-09-24 12:18 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (9.74 KB, patch)
2010-10-01 14:32 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (9.30 KB, patch)
2010-10-04 15:41 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-09-24 12:16:33 PDT
Add AudioBasicProcessorNode files
Comment 1 Chris Rogers 2010-09-24 12:18:22 PDT
Created attachment 68728 [details]
Patch
Comment 2 Chris Rogers 2010-10-01 14:32:48 PDT
Created attachment 69520 [details]
Patch
Comment 3 Kenneth Russell 2010-10-04 14:55:46 PDT
Comment on attachment 69520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69520&action=review

This basically looks good; couple of tiny changes. r- for the license text update discussed offline.

> WebCore/webaudio/AudioBasicProcessorNode.cpp:44
> +    , m_processor(0)

m_processor does not require explicit initialization.

> WebCore/webaudio/AudioBasicProcessorNode.cpp:85
> +            // FIXME: if we take "tailTime" into account, then we can avoid calling processor()->process() once the tail dies down.

Is tailTime concretely defined somewhere? If so, please mention where in the comment; otherwise, change to "tail time".
Comment 4 Chris Rogers 2010-10-04 15:41:23 PDT
Created attachment 69704 [details]
Patch
Comment 5 Chris Rogers 2010-10-04 15:42:10 PDT
license updated and comments addressed.
Comment 6 Kenneth Russell 2010-10-04 15:45:35 PDT
Comment on attachment 69704 [details]
Patch

Looks good to me.
Comment 7 WebKit Commit Bot 2010-10-05 00:45:12 PDT
Comment on attachment 69704 [details]
Patch

Rejecting patch 69704 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 69704]" exit_code: 2
Last 500 characters of output:
 69704 from bug 46495.
Parsing ChangeLog: /Projects/CommitQueue/WebCore/ChangeLog
Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	A	WebCore/webaudio/AudioBasicProcessorNode.cpp
	A	WebCore/webaudio/AudioBasicProcessorNode.h
Merge conflict during commit: Conflict at '/trunk/WebCore/ChangeLog' at /usr/local/git/libexec/git-core/git-svn line 572


Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1

Full output: http://queues.webkit.org/results/4220074
Comment 8 Adam Barth 2010-10-05 11:18:28 PDT
Comment on attachment 69704 [details]
Patch

That should have generated a retry.
Comment 9 WebKit Commit Bot 2010-10-05 11:48:53 PDT
Comment on attachment 69704 [details]
Patch

Clearing flags on attachment: 69704

Committed r69131: <http://trac.webkit.org/changeset/69131>
Comment 10 WebKit Commit Bot 2010-10-05 11:48:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Eric Seidel (no email) 2010-10-05 23:14:41 PDT
(In reply to comment #8)
> (From update of attachment 69704 [details])
> That should have generated a retry.

I don't think we detect that case.  It's not a "Checkout out of date" error.  It's a merge failure.