see patch THE LAST ONE!!! \O/
Created attachment 68705 [details] Patch
Comment on attachment 68705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68705&action=review > WebCore/ChangeLog:5 > + Remove dead code and fix headser includes in ResourceHandleWin Typo: "headser". > WebCore/platform/network/ResourceHandleInternal.h:100 > + , m_loadSynchronously(false) Why are you adding this? Adding a new data member does not match up with your description of this patch.
Created attachment 68706 [details] Patch
Comment on attachment 68706 [details] Patch Nice.
Comment on attachment 68706 [details] Patch Clearing flags on attachment: 68706 Committed r68371: <http://trac.webkit.org/changeset/68371>
All reviewed patches have been landed. Closing bug.
JFYI, this broke the build. Bots were fine though, apparently due to stale copy of ResourceHandleWin.h under WebKitBuild/include. Fixed at r68384.
Is this then indicative of a build system bug for Windows which needs to be filed?
(In reply to comment #8) > Is this then indicative of a build system bug for Windows which needs to be filed? Filed as https://bugs.webkit.org/show_bug.cgi?id=46479
(In reply to comment #9) > (In reply to comment #8) > > Is this then indicative of a build system bug for Windows which needs to be filed? > > Filed as https://bugs.webkit.org/show_bug.cgi?id=46479 Sorry, typo. Filed as https://bugs.webkit.org/show_bug.cgi?id=46638