Bug 46464 - SVGFEBlendElement doesn't support dynamic invalidation
Summary: SVGFEBlendElement doesn't support dynamic invalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45453
  Show dependency tree / graph
 
Reported: 2010-09-24 07:23 PDT by Renata Hodovan
Modified: 2010-09-26 10:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch for feBlend properties (916.57 KB, patch)
2010-09-24 07:51 PDT, Renata Hodovan 		no flags Details | Formatted Diff | Diff
Patch for feBlend properties (853.53 KB, patch)
2010-09-26 06:43 PDT, Renata Hodovan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renata Hodovan 2010-09-24 07:23:13 PDT 
SVGFEBlendElement doesn't support dynamic invalidation
Comment 1 Renata Hodovan 2010-09-24 07:51:26 PDT 
Created attachment 68680 [details]
Patch for feBlend properties
Comment 2 Dirk Schulze 2010-09-25 06:25:11 PDT 
Comment on attachment 68680 [details]
Patch for feBlend properties

View in context: https://bugs.webkit.org/attachment.cgi?id=68680&action=review

> LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt:9
> +Normal
> +Multiply
> +Multiply
> +Multiply
> +Screen
> +Darken
> +Lighten

Did you forget to delete the printf on creating the results?
Comment 3 Renata Hodovan 2010-09-25 06:40:54 PDT 
(In reply to comment #2)
> (From update of attachment 68680 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68680&action=review
> 
> > LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt:9
> > +Normal
> > +Multiply
> > +Multiply
> > +Multiply
> > +Screen
> > +Darken
> > +Lighten
> 
> Did you forget to delete the printf on creating the results?

No, it's just a description of the test.
Comment 4 Dirk Schulze 2010-09-25 08:45:05 PDT 
Ah i see. I would prefer to see this information after the description. Maybe with an extra description what this names mean. I'm also not sure if this provides relevant informations. If not, you may leave it out.
Comment 5 Renata Hodovan 2010-09-25 09:16:00 PDT 
(In reply to comment #4)
> Ah i see. I would prefer to see this information after the description. Maybe with an extra description what this names mean. I'm also not sure if this provides relevant informations. If not, you may leave it out.

I followed the example of feBlend filter by creating this test case (filters-blend-01-b-w3c.svg), but i can remove these lines if you think they are unrelevant :)
Comment 6 Dirk Schulze 2010-09-26 02:39:51 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > Ah i see. I would prefer to see this information after the description. Maybe with an extra description what this names mean. I'm also not sure if this provides relevant informations. If not, you may leave it out.
> 
> I followed the example of feBlend filter by creating this test case (filters-blend-01-b-w3c.svg), but i can remove these lines if you think they are unrelevant :)

I think so. Please leave it out.
Comment 7 Renata Hodovan 2010-09-26 06:43:03 PDT 
Created attachment 68847 [details]
Patch for feBlend properties
Comment 8 Dirk Schulze 2010-09-26 10:29:46 PDT 
Comment on attachment 68847 [details]
Patch for feBlend properties

LTM. r=me.
Comment 9 WebKit Commit Bot 2010-09-26 10:45:32 PDT 
Comment on attachment 68847 [details]
Patch for feBlend properties

Clearing flags on attachment: 68847

Committed r68344: <http://trac.webkit.org/changeset/68344>
Comment 10 WebKit Commit Bot 2010-09-26 10:45:40 PDT 
All reviewed patches have been landed.  Closing bug.