Bug 46464 – SVGFEBlendElement doesn't support dynamic invalidation

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Renata Hodovan]

SVGFEBlendElement doesn't support dynamic invalidation

[Renata Hodovan]

Created attachment 68680 [details]
Patch for feBlend properties

[Dirk Schulze]

Comment on attachment 68680 [details]
Patch for feBlend properties

View in context: https://bugs.webkit.org/attachment.cgi?id=68680&action=review

> LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt:9
> +Normal
> +Multiply
> +Multiply
> +Multiply
> +Screen
> +Darken
> +Lighten

Did you forget to delete the printf on creating the results?

[Renata Hodovan]

(In reply to comment #2)
> (From update of attachment 68680 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68680&action=review
> 
> > LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt:9
> > +Normal
> > +Multiply
> > +Multiply
> > +Multiply
> > +Screen
> > +Darken
> > +Lighten
> 
> Did you forget to delete the printf on creating the results?

No, it's just a description of the test.

[Dirk Schulze]

Ah i see. I would prefer to see this information after the description. Maybe with an extra description what this names mean. I'm also not sure if this provides relevant informations. If not, you may leave it out.

[Renata Hodovan]

(In reply to comment #4)
> Ah i see. I would prefer to see this information after the description. Maybe with an extra description what this names mean. I'm also not sure if this provides relevant informations. If not, you may leave it out.

I followed the example of feBlend filter by creating this test case (filters-blend-01-b-w3c.svg), but i can remove these lines if you think they are unrelevant :)

[Dirk Schulze]

(In reply to comment #5)
> (In reply to comment #4)
> > Ah i see. I would prefer to see this information after the description. Maybe with an extra description what this names mean. I'm also not sure if this provides relevant informations. If not, you may leave it out.
> 
> I followed the example of feBlend filter by creating this test case (filters-blend-01-b-w3c.svg), but i can remove these lines if you think they are unrelevant :)

I think so. Please leave it out.

[Renata Hodovan]

Created attachment 68847 [details]
Patch for feBlend properties

[Dirk Schulze]

Comment on attachment 68847 [details]
Patch for feBlend properties

LTM. r=me.

[WebKit Commit Bot]

Comment on attachment 68847 [details]
Patch for feBlend properties

Clearing flags on attachment: 68847

Committed r68344: <http://trac.webkit.org/changeset/68344>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.