Bug 46463 - Provide a Windows (CE) compatible inttypes.h
Summary: Provide a Windows (CE) compatible inttypes.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-24 07:01 PDT by Ismail Donmez
Modified: 2010-10-03 23:23 PDT (History)
8 users (show)

See Also:


Attachments
Modified inttypes.h from mingw (4.57 KB, text/plain)
2010-09-24 07:02 PDT, Ismail Donmez
no flags Details
Add inttypes.h, based on the version from http://code.google.com/p/msinttypes/ (7.67 KB, patch)
2010-09-24 07:46 PDT, Ismail Donmez
no flags Details | Formatted Diff | Diff
Mention that this fixes WinCE build. (7.69 KB, patch)
2010-09-24 07:58 PDT, Ismail Donmez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ismail Donmez 2010-09-24 07:01:20 PDT
Bug #46357 committed code using inttypes.h but Windows does not provide inttypes.h natively. I will attach a compatible inttypes.h based on a mingw header. The original file had no license associated with it, but since its a header I think LGPL applies.
Comment 1 Ismail Donmez 2010-09-24 07:02:03 PDT
Created attachment 68674 [details]
Modified inttypes.h from mingw
Comment 2 Ismail Donmez 2010-09-24 07:08:33 PDT
There is also http://code.google.com/p/msinttypes/ which is BSD licensed.
Comment 3 Csaba Osztrogonác 2010-09-24 07:11:47 PDT
(In reply to comment #2)
> There is also http://code.google.com/p/msinttypes/ which is BSD licensed.
I prefer this one.
Comment 4 Ismail Donmez 2010-09-24 07:46:59 PDT
Created attachment 68679 [details]
Add inttypes.h, based on the version from http://code.google.com/p/msinttypes/

Compile tested on Windows CE.
Comment 5 Csaba Osztrogonác 2010-09-24 07:55:18 PDT
Comment on attachment 68679 [details]
Add inttypes.h, based on the version from http://code.google.com/p/msinttypes/

Please mention in changelog why do we need it, otherwise LGTM.
Comment 6 Ismail Donmez 2010-09-24 07:58:47 PDT
Created attachment 68681 [details]
Mention that this fixes WinCE build.
Comment 7 WebKit Review Bot 2010-09-24 08:04:00 PDT
Attachment 68681 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/os-win32/inttypes.h:32:  #ifndef header guard has wrong style, please use: inttypes_h  [build/header_guard] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Csaba Osztrogonác 2010-09-24 08:55:44 PDT
(In reply to comment #7)
> Attachment 68681 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> JavaScriptCore/os-win32/inttypes.h:32:  #ifndef header guard has wrong style, please use: inttypes_h  [build/header_guard] [5]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

It is similar header guard as in os-win32/stdbool.h and os-win32/stdint.h .
Comment 9 Csaba Osztrogonác 2010-09-24 09:01:49 PDT
(In reply to comment #6)
> Created an attachment (id=68681) [details]
> Mention that this fixes WinCE build.

I cc-ed Adam, Brian and Eric. What do you think about it?
Won't hurt this the Windows build or the Chromium-Win build?
If no, I'm going to r+ it to make Win CE build happy.
Comment 10 Adam Roben (:aroben) 2010-09-24 09:08:04 PDT
(In reply to comment #9)
> (In reply to comment #6)
> > Created an attachment (id=68681) [details] [details]
> > Mention that this fixes WinCE build.
> 
> I cc-ed Adam, Brian and Eric. What do you think about it?
> Won't hurt this the Windows build or the Chromium-Win build?
> If no, I'm going to r+ it to make Win CE build happy.

Apple's Windows port doesn't use the os-win32 directory anymore, so this shouldn't have an effect on us.
Comment 11 WebKit Commit Bot 2010-09-24 13:12:08 PDT
Comment on attachment 68681 [details]
Mention that this fixes WinCE build.

Clearing flags on attachment: 68681

Committed r68285: <http://trac.webkit.org/changeset/68285>
Comment 12 WebKit Commit Bot 2010-09-24 13:12:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Brent Fulgham 2010-10-03 23:23:56 PDT
I've updated the WinCairo build to also use this new dependency.  In future, the new WinCairo buildbot should help avoid these kinds of breaks.