Bug 46463 – Provide a Windows (CE) compatible inttypes.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Ismail Donmez]

Bug #46357 committed code using inttypes.h but Windows does not provide inttypes.h natively. I will attach a compatible inttypes.h based on a mingw header. The original file had no license associated with it, but since its a header I think LGPL applies.

[Ismail Donmez]

Created attachment 68674 [details]
Modified inttypes.h from mingw

[Ismail Donmez]

There is also http://code.google.com/p/msinttypes/ which is BSD licensed.

[Csaba Osztrogonác]

(In reply to comment #2)
> There is also http://code.google.com/p/msinttypes/ which is BSD licensed.
I prefer this one.

[Ismail Donmez]

Created attachment 68679 [details]
Add inttypes.h, based on the version from http://code.google.com/p/msinttypes/

Compile tested on Windows CE.

[Csaba Osztrogonác]

Comment on attachment 68679 [details]
Add inttypes.h, based on the version from http://code.google.com/p/msinttypes/

Please mention in changelog why do we need it, otherwise LGTM.

[Ismail Donmez]

Created attachment 68681 [details]
Mention that this fixes WinCE build.

[WebKit Review Bot]

Attachment 68681 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/os-win32/inttypes.h:32:  #ifndef header guard has wrong style, please use: inttypes_h  [build/header_guard] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Csaba Osztrogonác]

(In reply to comment #7)
> Attachment 68681 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> JavaScriptCore/os-win32/inttypes.h:32:  #ifndef header guard has wrong style, please use: inttypes_h  [build/header_guard] [5]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

It is similar header guard as in os-win32/stdbool.h and os-win32/stdint.h .

[Csaba Osztrogonác]

(In reply to comment #6)
> Created an attachment (id=68681) [details]
> Mention that this fixes WinCE build.

I cc-ed Adam, Brian and Eric. What do you think about it?
Won't hurt this the Windows build or the Chromium-Win build?
If no, I'm going to r+ it to make Win CE build happy.

[Adam Roben (:aroben)]

(In reply to comment #9)
> (In reply to comment #6)
> > Created an attachment (id=68681) [details] [details]
> > Mention that this fixes WinCE build.
> 
> I cc-ed Adam, Brian and Eric. What do you think about it?
> Won't hurt this the Windows build or the Chromium-Win build?
> If no, I'm going to r+ it to make Win CE build happy.

Apple's Windows port doesn't use the os-win32 directory anymore, so this shouldn't have an effect on us.

[WebKit Commit Bot]

Comment on attachment 68681 [details]
Mention that this fixes WinCE build.

Clearing flags on attachment: 68681

Committed r68285: <http://trac.webkit.org/changeset/68285>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

I've updated the WinCairo build to also use this new dependency.  In future, the new WinCairo buildbot should help avoid these kinds of breaks.