Bug 46445 - [Chromium] Split webcore_html off webcore_remaining
Summary: [Chromium] Split webcore_html off webcore_remaining
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-23 20:51 PDT by Marc-Antoine Ruel
Modified: 2010-09-28 17:44 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.19 KB, patch)
2010-09-23 20:54 PDT, Marc-Antoine Ruel
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-Antoine Ruel 2010-09-23 20:51:26 PDT
webcore_remaining is still to large for certain 32 bits toolsets.
Comment 1 Marc-Antoine Ruel 2010-09-23 20:54:32 PDT
Created attachment 68643 [details]
Patch
Comment 2 Tony Chang 2010-09-23 20:57:31 PDT
Comment on attachment 68643 [details]
Patch

I take it the html directory has the most files?
Comment 3 Tony Chang 2010-09-23 20:58:24 PDT
Comment on attachment 68643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68643&action=review

> WebCore/WebCore.gyp/WebCore.gyp:1219
> -        ['exclude', '(android|cairo|cf|cg|curl|gtk|haiku|linux|mac|opentype|platform|posix|qt|soup|svg|symbian|win|wx)/'],
> +        ['exclude', '(android|cairo|cf|cg|curl|gtk|haiku|html|linux|mac|opentype|platform|posix|qt|soup|svg|symbian|win|wx)/'],

Nit: It might be a bit clearer to put html in a separate line with a comment about webcore_html.
Comment 4 Marc-Antoine Ruel 2010-09-23 21:03:45 PDT
There's rendering (135mb of .o) which will be the next one. There's bindings at 108mb but I'm not sure about the build ordering.

For having html on its own line, I did the same for svg and integrated it in the big line.
Comment 5 Tony Chang 2010-09-23 21:07:00 PDT
(In reply to comment #4)
> For having html on its own line, I did the same for svg and integrated it in the big line.

The comment is a bit confusing, but it's not a big deal either way.
Comment 6 Marc-Antoine Ruel 2010-09-24 06:10:34 PDT
The patch is broken on Windows, will update. Please do not commit.
Comment 7 Marc-Antoine Ruel 2010-09-28 17:23:16 PDT
Oh, the windows breakage was a fluke, the patch is good after all. Can someone c+ it?
Comment 8 WebKit Commit Bot 2010-09-28 17:44:16 PDT
Comment on attachment 68643 [details]
Patch

Clearing flags on attachment: 68643

Committed r68615: <http://trac.webkit.org/changeset/68615>
Comment 9 WebKit Commit Bot 2010-09-28 17:44:22 PDT
All reviewed patches have been landed.  Closing bug.