Bug 46434 - DOMWindow::revokeBlobURL erroneously uses ParsedURLString
Summary: DOMWindow::revokeBlobURL erroneously uses ParsedURLString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks: 42959
  Show dependency tree / graph
 
Reported: 2010-09-23 17:24 PDT by Alexey Proskuryakov
Modified: 2010-09-24 11:04 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (6.19 KB, patch)
2010-09-23 18:20 PDT, Jian Li 		ap: review+
jianli: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-09-23 17:24:06 PDT 
The argument comes from the caller, there is absolutely no guarantee that it's in the form KURL expects.

This causes assertion failures whenever it's not (e.g. revokeBlobURL("[foo bar]");

For absolute URLs, we should just pass a null base: KURL(KURL(), string). But if it can be relative, a proper base should be passed.
Comment 1 Jian Li 2010-09-23 18:20:50 PDT 
Created attachment 68635 [details]
Proposed Patch
Comment 2 Jian Li 2010-09-24 11:04:00 PDT 
Committed as http://trac.webkit.org/changeset/68275.