Bug 46432 – WebKit2 API: Need way to know when a frame is removed from the hierarchy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

WebKit2 API: Need way to know when a frame is removed from the hierarchy.

[Sam Weinig]

<rdar://problem/8414062>

[Sam Weinig]

Created attachment 68625 [details]
Patch

[WebKit Review Bot]

Attachment 68625 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:106:  Extra space between WKPageDidRemoveFrameFromHierarchyCallback and didRemoveFrameFromHierarchy  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:102:  Extra space between WKBundlePageDidRemoveFrameFromHierarchyCallback and didRemoveFrameFromHierarchy  [whitespace/declaration] [3]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Landed in r68220.

[Csaba Osztrogonác]

(In reply to comment #4)
> Landed in r68220.

Man! You break Qt buildbot again and again. The bot was red 
for 5 hours and 12 patch stucked in Qt EWS because of this changeset.

Please consider the redness of bots next time. I landed a 
buildfix in http://trac.webkit.org/changeset/68235.

Next time I will think of if I should roll out 
the culprit changeset instead of fixing ...

[Csaba Osztrogonác]

To avoid breaking Qt bot, I suggest you should wait green Qt 
EWS status bubble before r+ -ing a patch. It doesn't take a 
long time, max 5-10 minutes if the queue is empty.