WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46425
Add PluginProcessConnection and PluginProcessConnectionManager
https://bugs.webkit.org/show_bug.cgi?id=46425
Summary
Add PluginProcessConnection and PluginProcessConnectionManager
Anders Carlsson
Reported
2010-09-23 15:58:49 PDT
Add PluginProcessConnection and PluginProcessConnectionManager
Attachments
Patch
(18.04 KB, patch)
2010-09-23 16:24 PDT
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-09-23 16:24:14 PDT
Created
attachment 68615
[details]
Patch
WebKit Review Bot
Comment 2
2010-09-23 16:29:13 PDT
Attachment 68615
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2010-09-23 17:00:26 PDT
Comment on
attachment 68615
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=68615&action=review
> WebKit2/WebProcess/Plugins/PluginProcessConnection.h:67 > + // The CoreIPC connection.
I don't think this comment is adding anything.
> WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.cpp:73 > + } > + > + CoreIPC::Connection::Identifier connectionIdentifier; > + CoreIPC::MachPort connectionMachPort; > + if (!WebProcess::shared().connection()->sendSync(WebProcessProxyMessage::GetPluginProcessConnection, 0, > + CoreIPC::In(pluginPath), > + CoreIPC::Out(connectionMachPort), > + CoreIPC::Connection::NoTimeout)) > + return 0; > + > + connectionIdentifier = connectionMachPort.port(); > + if (!connectionIdentifier) > + return 0; > +
This looks very mac specific. Should it be in a mac specific directory? Otherwise looks good.
Anders Carlsson
Comment 4
2010-09-23 17:09:57 PDT
Committed
r68219
: <
http://trac.webkit.org/changeset/68219
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug