Bug 46418 - Make flexible boxes work with vertical text.
Summary: Make flexible boxes work with vertical text.
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, WPTImpact
Depends on: 46473
Blocks: 46123
  Show dependency tree / graph
 
Reported: 2010-09-23 15:26 PDT by Dave Hyatt
Modified: 2023-02-24 05:47 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-09-23 15:26:23 PDT 
Make flexible boxes work with vertical text.
Comment 1 Dave Hyatt 2010-09-23 19:21:55 PDT 
https://bugs.webkit.org/show_bug.cgi?id=46442... have to remove that code for flexible boxes eventually.... once we know how flexible boxes are supposed to work...
Comment 2 Adele Peterson 2010-10-29 15:14:38 PDT 
<rdar://problem/8612059>
Comment 4 Ryan Reno 2022-08-18 17:58:56 PDT 
I took a shot at this. RenderDeprecatedFlexibleBox is actually quite simple. To determine whether or not to do vertical or horizontal layout it just checks if the box has BoxOrient::Horizontal or not.

I tried using RenderObject::isHorizontalWritingMode to make that check for vertical or horizontal flow more similar to other standardized Renderers. However, it looks like the RenderObject bitfields are being set to horizontal writing mode no matter what CSS writing-mode value is specified.

So it's going to be slightly less easy than I initially thought.