Bug 46406 - Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
Summary: Fix a condition check in ServerProcess, which becomes relevant when reading b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-23 14:18 PDT by Dimitri Glazkov (Google)
Modified: 2010-09-23 14:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2010-09-23 14:23 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2010-09-23 14:18:55 PDT 
Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
Comment 1 Dimitri Glazkov (Google) 2010-09-23 14:23:24 PDT 
Created attachment 68588 [details]
Patch
Comment 2 David Levin 2010-09-23 14:26:51 PDT 
Is a test possible?
Comment 3 Dirk Pranke 2010-09-23 14:37:52 PDT 
not easily. this is embedded pretty close to some code reading directly off of sockets, and there's no easy way to mock it at the moment.

I need to revamp this code in the next few days and I will be adding a lot more unit testing at that point. I stepped through this with dglazkov, and the bug is real and the fix is the right one.
Comment 4 Dimitri Glazkov (Google) 2010-09-23 14:50:16 PDT 
Comment on attachment 68588 [details]
Patch

Clearing flags on attachment: 68588

Committed r68201: <http://trac.webkit.org/changeset/68201>
Comment 5 Dimitri Glazkov (Google) 2010-09-23 14:50:22 PDT 
All reviewed patches have been landed.  Closing bug.