Bug 46404 - Excessive Overhead in RegExp Entry Code
Summary: Excessive Overhead in RegExp Entry Code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-23 14:06 PDT by Michael Saboff
Modified: 2010-09-23 15:23 PDT (History)
1 user (show)

See Also:


Attachments
Patch that eliminates extraneous initialization of regexp results vector (3.04 KB, patch)
2010-09-23 14:17 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2010-09-23 14:06:08 PDT
Profiling shows the result vector initialization in RegExpObject::match, etc., to be 13.5% of the v8 regexp benchmark.
Comment 1 Michael Saboff 2010-09-23 14:17:47 PDT
Created attachment 68586 [details]
Patch that eliminates extraneous initialization of regexp results vector
Comment 2 Geoffrey Garen 2010-09-23 14:40:41 PDT
Comment on attachment 68586 [details]
Patch that eliminates extraneous initialization of regexp results vector

r=me
Comment 3 WebKit Commit Bot 2010-09-23 15:23:33 PDT
Comment on attachment 68586 [details]
Patch that eliminates extraneous initialization of regexp results vector

Clearing flags on attachment: 68586

Committed r68207: <http://trac.webkit.org/changeset/68207>
Comment 4 WebKit Commit Bot 2010-09-23 15:23:38 PDT
All reviewed patches have been landed.  Closing bug.