Bug 46402 - [Qt] QWebHapticFeedbackPlayer needs correct exposure through QWebKitPlatformPlugin
Summary: [Qt] QWebHapticFeedbackPlayer needs correct exposure through QWebKitPlatformP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 46345
  Show dependency treegraph
 
Reported: 2010-09-23 13:24 PDT by Ademar Reis
Modified: 2010-09-23 15:16 PDT (History)
1 user (show)

See Also:


Attachments
patch (1.72 KB, patch)
2010-09-23 13:32 PDT, Ademar Reis
no flags Details | Formatted Diff | Diff
patch #2 (3.66 KB, patch)
2010-09-23 14:32 PDT, Ademar Reis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ademar Reis 2010-09-23 13:24:45 PDT
QWebHapticFeedbackPlayer is exported through QWebKitPlatformPlugin::createExtension(), which returns QObject *.
(WebKit/qt/Api/qwebkitplatformplugin.h)

Haptics support is limited in trunk. I'm not sure if we should remove or fix this code.
(nevertheless, it's needed on the qtwebit-2.1 branch)

Patch is on the way
Comment 1 Ademar Reis 2010-09-23 13:32:18 PDT
Created attachment 68580 [details]
patch
Comment 2 Ademar Reis 2010-09-23 14:25:29 PDT
Changing the title of the bug because there are other fixes necessary. The patch will be updated as well.
Comment 3 Ademar Reis 2010-09-23 14:32:54 PDT
Created attachment 68591 [details]
patch #2
Comment 4 WebKit Commit Bot 2010-09-23 15:09:00 PDT
Comment on attachment 68591 [details]
patch #2

Clearing flags on attachment: 68591

Committed r68204: <http://trac.webkit.org/changeset/68204>
Comment 5 WebKit Commit Bot 2010-09-23 15:09:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ademar Reis 2010-09-23 15:16:34 PDT
Revision r68204 cherry-picked into qtwebkit-2.1 with commit 005c88d <http://gitorious.org/webkit/qtwebkit/commit/005c88d>