Bug 46383 – Fix ResourceHandleWin::cancel() for network resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 68558 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 68558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68558&action=review

> WebCore/platform/network/win/ResourceHandleWin.cpp:561
> +    if (d->m_requestHandle) {
> +        d->m_internetHandle = 0;
> +        InternetCloseHandle(d->m_requestHandle);
> +        InternetCloseHandle(d->m_connectHandle);
> +    } else

Do we need to clear out d->m_requestHandle, too?

[Patrick R. Gansterer]

(In reply to comment #2)
> Do we need to clear out d->m_requestHandle, too?
No, d->m_requestHandle indicates if it is a network request and won't be used after cancel().

[Adam Roben (:aroben)]

(In reply to comment #3)
> (In reply to comment #2)
> > Do we need to clear out d->m_requestHandle, too?
> No, d->m_requestHandle indicates if it is a network request and won't be used after cancel().

That seems like a tricky rule to follow. Maybe we should have a separate member that indicates whether it's a network request or not?

[Patrick R. Gansterer]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Do we need to clear out d->m_requestHandle, too?
> > No, d->m_requestHandle indicates if it is a network request and won't be used after cancel().
> 
> That seems like a tricky rule to follow. Maybe we should have a separate member that indicates whether it's a network request or not?
Might be a good idea. Maybe we can address this when adding handling for data:// urls?

[WebKit Commit Bot]

Comment on attachment 68558 [details]
Patch

Clearing flags on attachment: 68558

Committed r68184: <http://trac.webkit.org/changeset/68184>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.