Bug 46381 - make fast/events/standalone-image-drag-to-editable.html non-flakey
Summary: make fast/events/standalone-image-drag-to-editable.html non-flakey
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
Depends on:
Reported: 2010-09-23 11:56 PDT by Tony Chang
Modified: 2010-09-23 16:37 PDT (History)
3 users (show)

See Also:

Patch (21.28 KB, patch)
2010-09-23 12:00 PDT, Tony Chang
levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-09-23 11:56:54 PDT
[chromium] make fast/events/standalone-image-drag-to-editable.html non-flakey
Comment 1 Tony Chang 2010-09-23 12:00:09 PDT
Created attachment 68555 [details]
Comment 2 Tony Chang 2010-09-23 12:04:50 PDT
Actually, this isn't chromium specific since this changes the test for all platforms.
Comment 3 David Levin 2010-09-23 15:01:34 PDT
Comment on attachment 68555 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=68555&action=review

Just some minor fixes to do on landing.

> LayoutTests/fast/events/resources/standalone-image-drag-to-editable-frame.html:10
> +      layoutTestController.notifyDone();

if (window.layoutTestController)

> LayoutTests/fast/events/resources/standalone-image-drag-to-editable-frame.html:13
> +          layoutTestController.notifyDone();

if (window.layoutTestController)
Comment 4 Tony Chang 2010-09-23 16:36:13 PDT
Committed r68213: <http://trac.webkit.org/changeset/68213>
Comment 5 Tony Chang 2010-09-23 16:37:25 PDT
Thanks for the review.  I added a check for window.layoutTestController to the beginning of the function before committing.