Bug 46378 - Rename width/height on line boxes to logicalWidth/logicalHeight.
Summary: Rename width/height on line boxes to logicalWidth/logicalHeight.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency tree / graph
 
Reported: 2010-09-23 11:36 PDT by Dave Hyatt
Modified: 2010-09-23 12:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch (76.97 KB, patch)
2010-09-23 11:38 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-09-23 11:36:45 PDT 
Rename width/height on line boxes to logicalWidth/logicalHeight.
Comment 1 Dave Hyatt 2010-09-23 11:38:38 PDT 
Created attachment 68552 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-23 11:45:26 PDT 
Attachment 68552 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/InlineTextBox.cpp:796:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.cpp:972:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2010-09-23 12:18:42 PDT 
Fixed in r68177.