RESOLVED FIXED 46378
Rename width/height on line boxes to logicalWidth/logicalHeight. 
https://bugs.webkit.org/show_bug.cgi?id=46378
Summary Rename width/height on line boxes to logicalWidth/logicalHeight.
Dave Hyatt
Reported 2010-09-23 11:36:45 PDT
Rename width/height on line boxes to logicalWidth/logicalHeight.
Attachments
Patch (76.97 KB, patch)
2010-09-23 11:38 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-23 11:38:38 PDT
Created attachment 68552 [details] Patch
WebKit Review Bot
Comment 2 2010-09-23 11:45:26 PDT
Attachment 68552 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/rendering/InlineTextBox.cpp:796: One space before end of line comments [whitespace/comments] [5] WebCore/rendering/InlineTextBox.cpp:972: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2010-09-23 12:18:42 PDT
Fixed in r68177.
Note You need to log in before you can comment on or make changes to this bug.