Bug 46360 - [WinCairo] Add Build Slave
Summary: [WinCairo] Add Build Slave
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-23 09:22 PDT by Brent Fulgham
Modified: 2010-09-30 09:33 PDT (History)
3 users (show)

See Also:


Attachments
Patch to add the WinCairo builder to the hierarchy. (2.30 KB, patch)
2010-09-23 09:51 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Updated version with missing scheduler entry. (3.17 KB, patch)
2010-09-27 11:58 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Revised with 'wincairo' naming due to BuildBot syntax issues. (5.43 KB, patch)
2010-09-28 14:42 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2010-09-23 09:22:30 PDT
The attached patch adds a WinCairo build slave to the suite of build bots.
Comment 1 Brent Fulgham 2010-09-23 09:51:58 PDT
Created attachment 68533 [details]
Patch to add the WinCairo builder to the hierarchy.
Comment 2 Brent Fulgham 2010-09-27 11:58:06 PDT
Created attachment 68941 [details]
Updated version with missing scheduler entry.

After running a few tests with a simulated BuildMaster, I realized that the configuration won't work without a corresponding 'Scheduler' entry.  So I've revised the patch with that missing component.
Comment 3 Brent Fulgham 2010-09-28 14:42:31 PDT
Created attachment 69107 [details]
Revised with 'wincairo' naming due to BuildBot syntax issues.

Using the original "cairo-win32" platform label seemed to cause some problems with BuildBot (it was stripping off the "-win32" suffix, and passing only "cairo" as the platform.)  To be consistent with the port's name and general use, I changed the build-webkit configuration flag from "--cairo-win32" to "--wincairo".
Comment 4 Brent Fulgham 2010-09-29 10:54:06 PDT
Build bot now updates and runs correctly.
Comment 5 Martin Robinson 2010-09-29 17:07:37 PDT
Comment on attachment 69107 [details]
Revised with 'wincairo' naming due to BuildBot syntax issues.

Looks sane to me.
Comment 6 Eric Seidel (no email) 2010-09-29 20:23:11 PDT
Yeah, rs=me too.
Comment 7 Eric Seidel (no email) 2010-09-30 03:21:49 PDT
Comment on attachment 68941 [details]
Updated version with missing scheduler entry.

Cleared Mark Rowe's review+ from obsolete attachment 68941 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 8 Brent Fulgham 2010-09-30 09:05:18 PDT
Landed in http://trac.webkit.org/changeset/68744.
Comment 9 William Siegrist 2010-09-30 09:33:24 PDT
You had a syntax error in config.json, but I fixed it in 68791.

Master restart started.