Bug 46354 - [EFL] Fix warnings during build
Summary: [EFL] Fix warnings during build
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Lucas De Marchi
Depends on:
Reported: 2010-09-23 08:10 PDT by Lucas De Marchi
Modified: 2010-09-23 09:57 PDT (History)
4 users (show)

See Also:

Patch (3.96 KB, patch)
2010-09-23 08:14 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff
Patch (3.98 KB, patch)
2010-09-23 09:29 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2010-09-23 08:10:29 PDT
[EFL] Fix warnings during build
Comment 1 Lucas De Marchi 2010-09-23 08:14:24 PDT
Created attachment 68521 [details]
Comment 2 WebKit Review Bot 2010-09-23 08:15:34 PDT
Attachment 68521 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/efl/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
WebKit/efl/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
WebKit/efl/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Lucas De Marchi 2010-09-23 09:29:28 PDT
Created attachment 68528 [details]

New patch removing the tab characters
Comment 4 Csaba Osztrogonác 2010-09-23 09:52:20 PDT
Comment on attachment 68528 [details]

LGTM, r=me
Comment 5 Lucas De Marchi 2010-09-23 09:57:02 PDT
Comment on attachment 68528 [details]

Clearing flags on attachment: 68528

Committed r68154: <http://trac.webkit.org/changeset/68154>
Comment 6 Lucas De Marchi 2010-09-23 09:57:11 PDT
All reviewed patches have been landed.  Closing bug.