Bug 46350 - IDBTransaction missing layout tests.
Summary: IDBTransaction missing layout tests.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-23 07:42 PDT by Andrei Popescu
Modified: 2012-01-27 13:48 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.92 KB, patch)
2010-09-23 07:47 PDT, Andrei Popescu 		jorlow: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Popescu 2010-09-23 07:42:09 PDT 
IDBTransaction missing layout tests.
Comment 1 Andrei Popescu 2010-09-23 07:47:49 PDT 
Created attachment 68517 [details]
Patch
Comment 2 Jeremy Orlow 2010-09-23 08:12:42 PDT 
Comment on attachment 68517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68517&action=review

> LayoutTests/storage/indexeddb/transaction-get.html:18
> +        debug("Accessing a committed transaction should throw");

This needs to log a failure.
Comment 3 Joshua Bell 2012-01-27 13:48:46 PST 
Tests for these cases now exist in storage/indexeddb/transaction-basics.html:

    evalAndExpectException("index.openCursor()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("index.openKeyCursor()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("index.get(0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("index.getKey(0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("index.count()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");

    evalAndExpectException("store.put(0, 0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.add(0, 0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.delete(0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.clear()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.get(0)", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");
    evalAndExpectException("store.openCursor()", "IDBDatabaseException.TRANSACTION_INACTIVE_ERR");

And storage/indexeddb/transaction-and-objectstore-calls.html:

    evalAndExpectException("trans.objectStore('store')", "webkitIDBDatabaseException.NOT_ALLOWED_ERR");
    evalAndExpectException("store.index('index')", "webkitIDBDatabaseException.NOT_ALLOWED_ERR");

No need to try and land this one.