Bug 46346 – Web Inspector: [REGRESSION] Keyboard-Navigating the dom in the inspector doesn't highlight that dom node in the window anymore

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Martin Häcker]

Instead it only listens to the mouse hovering above a dom node - which is verry annoying if you want to precisely navigate to an element while looking at the dom to see if you have the right one.

[Pavel Feldman]

So highlight should be visible for the element that has been selected / hovered last. I.e. traversing elements using keyboard should highlight the currently selected one, not falling back to the hovered element in 2 sec. Moving the mouse afterwards should highlight hovered element.

[Pavel Podivilov]

Created attachment 68513 [details]
Proposed patch.

[Pavel Feldman]

Comment on attachment 68513 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=68513&action=review

> WebCore/inspector/front-end/treeoutline.js:797
> +    this.select(false, true);

false -> this.

[Pavel Podivilov]

(In reply to comment #3)
> (From update of attachment 68513 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68513&action=review
> 
> > WebCore/inspector/front-end/treeoutline.js:797
> > +    this.select(false, true);
> 
> false -> this.

onselect and select functions have different signatures:
onselect: function(treeElement, selectedByUser)
TreeElement.prototype.select = function(supressOnSelect, selectedByUser)

So select method has boolean supressOnSelect as it's first parameter.

[WebKit Commit Bot]

Comment on attachment 68513 [details]
Proposed patch.

Clearing flags on attachment: 68513

Committed r68140: <http://trac.webkit.org/changeset/68140>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.