Bug 46346 - Web Inspector: [REGRESSION] Keyboard-Navigating the dom in the inspector doesn't highlight that dom node in the window anymore
Summary: Web Inspector: [REGRESSION] Keyboard-Navigating the dom in the inspector does...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-23 06:14 PDT by Martin Häcker
Modified: 2010-09-23 08:21 PDT (History)
11 users (show)

See Also:

Attachments
Proposed patch. (2.76 KB, patch)
2010-09-23 06:57 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Häcker 2010-09-23 06:14:12 PDT 
Instead it only listens to the mouse hovering above a dom node - which is verry annoying if you want to precisely navigate to an element while looking at the dom to see if you have the right one.
Comment 1 Pavel Feldman 2010-09-23 06:27:51 PDT 
So highlight should be visible for the element that has been selected / hovered last. I.e. traversing elements using keyboard should highlight the currently selected one, not falling back to the hovered element in 2 sec. Moving the mouse afterwards should highlight hovered element.
Comment 2 Pavel Podivilov 2010-09-23 06:57:04 PDT 
Created attachment 68513 [details]
Proposed patch.
Comment 3 Pavel Feldman 2010-09-23 07:06:46 PDT 
Comment on attachment 68513 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=68513&action=review

> WebCore/inspector/front-end/treeoutline.js:797
> +    this.select(false, true);

false -> this.
Comment 4 Pavel Podivilov 2010-09-23 07:18:14 PDT 
(In reply to comment #3)
> (From update of attachment 68513 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68513&action=review
> 
> > WebCore/inspector/front-end/treeoutline.js:797
> > +    this.select(false, true);
> 
> false -> this.

onselect and select functions have different signatures:
onselect: function(treeElement, selectedByUser)
TreeElement.prototype.select = function(supressOnSelect, selectedByUser)

So select method has boolean supressOnSelect as it's first parameter.
Comment 5 WebKit Commit Bot 2010-09-23 08:20:56 PDT 
Comment on attachment 68513 [details]
Proposed patch.

Clearing flags on attachment: 68513

Committed r68140: <http://trac.webkit.org/changeset/68140>
Comment 6 WebKit Commit Bot 2010-09-23 08:21:01 PDT 
All reviewed patches have been landed.  Closing bug.