Bug 46337 - Rebaseline a few repainting tests for Chromium.
Summary: Rebaseline a few repainting tests for Chromium.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-22 21:17 PDT by Dimitri Glazkov (Google)
Modified: 2010-09-23 10:14 PDT (History)
2 users (show)

See Also:

Attachments
Patch (189.16 KB, patch)
2010-09-22 21:19 PDT, Dimitri Glazkov (Google) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2010-09-22 21:17:42 PDT 
Rebaseline a few repainting tests for Chromium.
Comment 1 Dimitri Glazkov (Google) 2010-09-22 21:19:16 PDT 
Created attachment 68499 [details]
Patch
Comment 2 Adam Barth 2010-09-22 21:27:01 PDT 
Comment on attachment 68499 [details]
Patch

Not entirely sure how to review this change, but it looks reasonable.
Comment 3 Dimitri Glazkov (Google) 2010-09-22 21:34:06 PDT 
Committed r68121: <http://trac.webkit.org/changeset/68121>
Comment 4 Tony Chang 2010-09-23 10:08:40 PDT 
Out of curiosity, why were the mac tests failing (they don't appear to have scrollbars, which is the obvious difference from upstream)?
Comment 5 Dimitri Glazkov (Google) 2010-09-23 10:14:59 PDT 
(In reply to comment #4)
> Out of curiosity, why were the mac tests failing (they don't appear to have scrollbars, which is the obvious difference from upstream)?

The repaint squares (and their quantity -- including the whole screen repaints) are going to be different on Chromium Mac, because we don't use NSView, but the tests actually pass. The upstream results don't have scrollbars either, btw:

http://trac.webkit.org/export/68051/trunk/LayoutTests/platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png
http://trac.webkit.org/export/68051/trunk/LayoutTests/platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png
...