RESOLVED FIXED 46337
Rebaseline a few repainting tests for Chromium. 
https://bugs.webkit.org/show_bug.cgi?id=46337
Summary Rebaseline a few repainting tests for Chromium.
Dimitri Glazkov (Google)
Reported 2010-09-22 21:17:42 PDT
Rebaseline a few repainting tests for Chromium.
Attachments
Patch (189.16 KB, patch)
2010-09-22 21:19 PDT, Dimitri Glazkov (Google) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-09-22 21:19:16 PDT
Created attachment 68499 [details] Patch
Adam Barth
Comment 2 2010-09-22 21:27:01 PDT
Comment on attachment 68499 [details] Patch Not entirely sure how to review this change, but it looks reasonable.
Dimitri Glazkov (Google)
Comment 3 2010-09-22 21:34:06 PDT
Committed r68121: <http://trac.webkit.org/changeset/68121>
Tony Chang
Comment 4 2010-09-23 10:08:40 PDT
Out of curiosity, why were the mac tests failing (they don't appear to have scrollbars, which is the obvious difference from upstream)?
Dimitri Glazkov (Google)
Comment 5 2010-09-23 10:14:59 PDT
(In reply to comment #4) > Out of curiosity, why were the mac tests failing (they don't appear to have scrollbars, which is the obvious difference from upstream)? The repaint squares (and their quantity -- including the whole screen repaints) are going to be different on Chromium Mac, because we don't use NSView, but the tests actually pass. The upstream results don't have scrollbars either, btw: http://trac.webkit.org/export/68051/trunk/LayoutTests/platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png http://trac.webkit.org/export/68051/trunk/LayoutTests/platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png ...
Note You need to log in before you can comment on or make changes to this bug.