Bug 46331 - minor cleanup of rebaseline-chromium-webkit-tests and gpu test_expectations
Summary: minor cleanup of rebaseline-chromium-webkit-tests and gpu test_expectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-22 18:39 PDT by Dirk Pranke
Modified: 2010-09-23 14:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2010-09-22 18:41 PDT, Dirk Pranke 		abarth: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-09-22 18:39:29 PDT 
minor cleanup of rebaseline-chromium-webkit-tests and gpu test_expectations
Comment 1 Dirk Pranke 2010-09-22 18:41:26 PDT 
Created attachment 68491 [details]
Patch
Comment 2 Adam Barth 2010-09-22 19:49:09 PDT 
Comment on attachment 68491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68491&action=review

This seems like patches.  I'd just landed the test_expectation.txt part without review.

> WebKitTools/ChangeLog:7
> +        the tool to breat on a git checkout, but that needs to be tracked

breat => break

> WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:592
> -            # self._scm.add(path)
> +            self._scm.add(path)

Seems like we need a test for whatever this does.
Comment 3 Dirk Pranke 2010-09-22 20:11:08 PDT 
I'll just fix the code over in https://bugs.webkit.org/show_bug.cgi?id=46332 and land the expectation change separately, then. 

I will add a test for that :)
Comment 4 Dirk Pranke 2010-09-23 14:56:27 PDT 
Committed r68202: <http://trac.webkit.org/changeset/68202>