Created attachment 68481 [details]
test case (will crash)
At some point, someone went over WebCore to fix all issues like this. Either we added new ones, or this just fell through cracks.
Created attachment 68577 [details]
Comment on attachment 68577 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=68577&action=review
Since you’re a committer I’ll let you set the commit-queue flag yourself if you decide you don’t want to fix the minor typos and such I mentioned above.
> + attach/detach may not be always paired.
Tiny grammatical nitpick: "may not always be paired" is better phrasing.
> + // The node iterator can be detached wihtout having been atatched if its root node didn't have a document
Did you put this line in intentionally? If so, what purpose does it serve? Would a comment make that clearer? Would some logging after the fact be helpful?
> Did you put this line in intentionally?
I think I was beginning to write some other subtest, but then decided that it wasn't relevant. This line has no effect, so I removed it.
Mass moving XML DOM bugs to the "DOM" Component.