Skia's safeRef() and safeUnref() functions are undefined on NULL pointers. SkSafeRef() and SkSafeUnref() should be used instead. Patch forthcoming.
Created attachment 68450 [details] Use SkSafeRef/Unref instead of safeRef/Unref
Comment on attachment 68450 [details] Use SkSafeRef/Unref instead of safeRef/Unref View in context: https://bugs.webkit.org/attachment.cgi?id=68450&action=review > WebCore/platform/graphics/skia/PlatformContextSkia.cpp:165 > // Up the ref count of these. saveRef does nothing if 'this' is NULL. This comment is incorrect. Please update.
Created attachment 68470 [details] grep missed saveRef, fixed.
Attachment 68470 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/skia/PlatformContextSkia.cpp:165: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 68450 [details] Use SkSafeRef/Unref instead of safeRef/Unref Cleared David Levin's review+ from obsolete attachment 68450 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment on attachment 68470 [details] grep missed saveRef, fixed. View in context: https://bugs.webkit.org/attachment.cgi?id=68470&action=review > WebCore/platform/graphics/skia/PlatformContextSkia.cpp:165 > + // Up the ref count of these. SkSafeRef does nothing if its argument is NULL. Use 0 instead of NULL.
Why did this get put up for review again just to fix a comment? If you want to use the commit queue, then just attach the patch as if you were going to land it (with the reviewer filled in and nits fixed). Then just mark the patch as cq+ (or get any committer to do so). No need for a new review :)
Created attachment 68530 [details] Use 0 instead of NULL in comment to appease style bot.
Created attachment 68531 [details] Fill in reviewer
Sorry, I infrequently submit webkit patches.
Landed by jhawkins as r68165.
http://trac.webkit.org/changeset/68165 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/68163 http://trac.webkit.org/changeset/68164 http://trac.webkit.org/changeset/68165 http://trac.webkit.org/changeset/68166 http://trac.webkit.org/changeset/68167 http://trac.webkit.org/changeset/68168 http://trac.webkit.org/changeset/68169