Bug 46307 - Create one time initialization block for WebView's initWithFrame
Summary: Create one time initialization block for WebView's initWithFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P5 Trivial
Assignee: Matthew Delaney
URL:
Keywords:
Depends on:
Blocks: 45362
  Show dependency treegraph
 
Reported: 2010-09-22 14:05 PDT by Matthew Delaney
Modified: 2010-09-23 06:37 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.63 KB, patch)
2010-09-22 14:50 PDT, Matthew Delaney
no flags Details | Formatted Diff | Diff
update per comments (1.62 KB, patch)
2010-09-22 14:58 PDT, Matthew Delaney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2010-09-22 14:05:37 PDT
There is a block of one time initialization code in WebView.cpp's initWithFrame that doesn't need to to be run for each new WebView and could be wrapped in a one time run block.
Comment 1 Matthew Delaney 2010-09-22 14:50:15 PDT
Created attachment 68446 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-09-22 14:53:06 PDT
Comment on attachment 68446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68446&action=review

> WebKit/win/WebView.cpp:2564
> +    static bool didOneTimeInitialization = false;

No need for the " = false". That happens automatically.
Comment 3 Matthew Delaney 2010-09-22 14:58:05 PDT
Created attachment 68447 [details]
update per comments

Addressed comment.
Comment 4 Adam Roben (:aroben) 2010-09-22 14:59:07 PDT
Comment on attachment 68447 [details]
update per comments

Going to wait for the EWS bot to look at this before I cq+ it.
Comment 5 Eric Seidel (no email) 2010-09-23 03:18:56 PDT
Comment on attachment 68446 [details]
Patch

Cleared Adam Roben's review+ from obsolete attachment 68446 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 6 WebKit Commit Bot 2010-09-23 06:37:13 PDT
Comment on attachment 68447 [details]
update per comments

Clearing flags on attachment: 68447

Committed r68133: <http://trac.webkit.org/changeset/68133>
Comment 7 WebKit Commit Bot 2010-09-23 06:37:18 PDT
All reviewed patches have been landed.  Closing bug.