Bug 46304 – display:inline should become display:inline-block when an object's block flow does not match its parent's

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

The writing mode spec says that a display:inline child with different block-flow than its parent becomes an inline-block.

[Dave Hyatt]

Created attachment 68437 [details]
Patch

Comment on attachment 68437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68437&action=review

> WebCore/css/CSSStyleSelector.cpp:1565
> +    adjustRenderStyle(style(), parentStyle, 0);

I think you want the renderer’s parent’s style() here, not parentStyle, which is just the style to inherit from.

> WebCore/css/CSSStyleSelector.cpp:1719
> +        if (style->display() == INLINE && style->blockFlow() != parentStyle->blockFlow())

I think parentStyle can be 0.

[Dave Hyatt]

Created attachment 68438 [details]
Patch

Comment on attachment 68438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68438&action=review

> LayoutTests/fast/blockflow/display-mutation.html:20
>  \ No newline at end of file

Please fix.

[Dave Hyatt]

Created attachment 68443 [details]
Patch

Comment on attachment 68443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68443&action=review

> LayoutTests/fast/blockflow/display-mutation.html:20
>  \ No newline at end of file

Please fix!!!1

[Dave Hyatt]

(In reply to comment #6)
> (From update of attachment 68443 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68443&action=review
> 
> > LayoutTests/fast/blockflow/display-mutation.html:20
> >  \ No newline at end of file
> 
> Please fix!!!1

Ok!!!

[Dave Hyatt]

Fixed.