Bug 46300 - GTK client needs updating when live iframe element is moved between pages
Summary: GTK client needs updating when live iframe element is moved between pages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Jenn Braithwaite
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-22 13:37 PDT by Jenn Braithwaite
Modified: 2010-09-26 23:24 PDT (History)
4 users (show)

See Also:

Attachments
Test case from bug 44713 can be used to repro this bug. (64 bytes, text/plain)
2010-09-22 13:37 PDT, Jenn Braithwaite 		no flags Details
Patch (6.62 KB, patch)
2010-09-24 12:24 PDT, Jenn Braithwaite 		no flags Details | Formatted Diff | Diff
patch (6.56 KB, patch)
2010-09-24 13:07 PDT, Jenn Braithwaite 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jenn Braithwaite 2010-09-22 13:37:14 PDT 
Created attachment 68432 [details]
Test case from bug 44713 can be used to repro this bug.

WebKitWebFrame needs to update its webview to the webview of the new parent after the frame has been re-parented.

GDB reports a leak with the attached test case (from bug 44713).

See bug 34382 and its fix http://trac.webkit.org/changeset/54938 for related changes.
Comment 1 Jenn Braithwaite 2010-09-24 12:24:41 PDT 
Created attachment 68729 [details]
Patch
Comment 2 Jenn Braithwaite 2010-09-24 13:07:29 PDT 
Created attachment 68736 [details]
patch

Updated patch after merging with head of tree. No other changes.
Comment 3 David Levin 2010-09-24 14:08:01 PDT 
Test to see if email is sent.
Comment 4 David Levin 2010-09-24 14:10:50 PDT 
test
Comment 5 WebKit Commit Bot 2010-09-26 23:24:50 PDT 
Comment on attachment 68736 [details]
patch

Clearing flags on attachment: 68736

Committed r68373: <http://trac.webkit.org/changeset/68373>
Comment 6 WebKit Commit Bot 2010-09-26 23:24:57 PDT 
All reviewed patches have been landed.  Closing bug.